| Message ID | 20191228183538.26189-5-tiny.windzz@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/13] mailbox: altera: convert to devm_platform_ioremap_resource | expand |
On Sat, 2019-12-28 at 18:35 +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Thanks! > drivers/mailbox/bcm2835-mailbox.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835- > mailbox.c > index 39761d190545..79f93c9c7682 100644 > --- a/drivers/mailbox/bcm2835-mailbox.c > +++ b/drivers/mailbox/bcm2835-mailbox.c > @@ -137,7 +137,6 @@ static int bcm2835_mbox_probe(struct platform_device > *pdev) > { > struct device *dev = &pdev->dev; > int ret = 0; > - struct resource *iomem; > struct bcm2835_mbox *mbox; > > mbox = devm_kzalloc(dev, sizeof(*mbox), GFP_KERNEL); > @@ -153,8 +152,7 @@ static int bcm2835_mbox_probe(struct platform_device > *pdev) > return -ENODEV; > } > > - iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - mbox->regs = devm_ioremap_resource(&pdev->dev, iomem); > + mbox->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(mbox->regs)) { > ret = PTR_ERR(mbox->regs); > dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c index 39761d190545..79f93c9c7682 100644 --- a/drivers/mailbox/bcm2835-mailbox.c +++ b/drivers/mailbox/bcm2835-mailbox.c @@ -137,7 +137,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; int ret = 0; - struct resource *iomem; struct bcm2835_mbox *mbox; mbox = devm_kzalloc(dev, sizeof(*mbox), GFP_KERNEL); @@ -153,8 +152,7 @@ static int bcm2835_mbox_probe(struct platform_device *pdev) return -ENODEV; } - iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - mbox->regs = devm_ioremap_resource(&pdev->dev, iomem); + mbox->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(mbox->regs)) { ret = PTR_ERR(mbox->regs); dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/mailbox/bcm2835-mailbox.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)