Message ID | 20200113140427.1.I5e35e29bebe575e091177c4f82606c15370b71d7@changeid (mailing list archive) |
---|---|
State | Accepted |
Commit | 5f9935f514d66ddba868e587d9e976a567232547 |
Headers | show |
Series | drm/msm: Fix error about comments within a comment block | expand |
On Mon, Jan 13, 2020 at 02:04:46PM -0800, Douglas Anderson wrote: > My compiler yells: > .../drivers/gpu/drm/msm/adreno/adreno_gpu.c:69:27: > error: '/*' within block comment [-Werror,-Wcomment] > > Let's fix. grumble something about the road being paved with good intentions.... Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org> > Fixes: 6a0dea02c2c4 ("drm/msm: support firmware-name for zap fw (v2)") > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index c146c3b8f52b..7fd29829b2fa 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -67,7 +67,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname, > * > * If the firmware-name property is found, we bypass the > * adreno_request_fw() mechanism, because we don't need to handle > - * the /lib/firmware/qcom/* vs /lib/firmware/* case. > + * the /lib/firmware/qcom/... vs /lib/firmware/... case. > * > * If the firmware-name property is not found, for backwards > * compatibility we fall back to the fwname from the gpulist > -- > 2.25.0.rc1.283.g88dfdc4193-goog >
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index c146c3b8f52b..7fd29829b2fa 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -67,7 +67,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname, * * If the firmware-name property is found, we bypass the * adreno_request_fw() mechanism, because we don't need to handle - * the /lib/firmware/qcom/* vs /lib/firmware/* case. + * the /lib/firmware/qcom/... vs /lib/firmware/... case. * * If the firmware-name property is not found, for backwards * compatibility we fall back to the fwname from the gpulist
My compiler yells: .../drivers/gpu/drm/msm/adreno/adreno_gpu.c:69:27: error: '/*' within block comment [-Werror,-Wcomment] Let's fix. Fixes: 6a0dea02c2c4 ("drm/msm: support firmware-name for zap fw (v2)") Signed-off-by: Douglas Anderson <dianders@chromium.org> --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)