| Message ID | 20200122013240.132861-1-chenzhou10@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7af43a76695db71a57203793fb9dd3c81a5783b1 |
| Headers | show |
| Series | [-next,v2] backlight: qcom-wled: fix unsigned comparison to zero | expand |
On Wed, Jan 22, 2020 at 09:32:40AM +0800, Chen Zhou wrote: > Fixes coccicheck warning: > ./drivers/video/backlight/qcom-wled.c:1104:5-15: > WARNING: Unsigned expression compared with zero: string_len > 0 > > The unsigned variable string_len is assigned a return value from the call > to of_property_count_elems_of_size(), which may return negative error code. > > Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3") > Signed-off-by: Chen Zhou <chenzhou10@huawei.com> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > > changes in v2: > - fix commit message description. > > --- > drivers/video/backlight/qcom-wled.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > index d46052d..3d276b3 100644 > --- a/drivers/video/backlight/qcom-wled.c > +++ b/drivers/video/backlight/qcom-wled.c > @@ -956,8 +956,8 @@ static int wled_configure(struct wled *wled, int version) > struct wled_config *cfg = &wled->cfg; > struct device *dev = wled->dev; > const __be32 *prop_addr; > - u32 size, val, c, string_len; > - int rc, i, j; > + u32 size, val, c; > + int rc, i, j, string_len; > > const struct wled_u32_opts *u32_opts = NULL; > const struct wled_u32_opts wled3_opts[] = { > -- > 2.7.4 >
On 2020-01-22 16:25, Daniel Thompson wrote: > On Wed, Jan 22, 2020 at 09:32:40AM +0800, Chen Zhou wrote: >> Fixes coccicheck warning: >> ./drivers/video/backlight/qcom-wled.c:1104:5-15: >> WARNING: Unsigned expression compared with zero: string_len > 0 >> >> The unsigned variable string_len is assigned a return value from the >> call >> to of_property_count_elems_of_size(), which may return negative error >> code. >> >> Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for >> WLED3") >> Signed-off-by: Chen Zhou <chenzhou10@huawei.com> >> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > Reviewed-by: Kiran Gunda <kgunda@codeaurora.org> >> --- >> >> changes in v2: >> - fix commit message description. >> >> --- >> drivers/video/backlight/qcom-wled.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/video/backlight/qcom-wled.c >> b/drivers/video/backlight/qcom-wled.c >> index d46052d..3d276b3 100644 >> --- a/drivers/video/backlight/qcom-wled.c >> +++ b/drivers/video/backlight/qcom-wled.c >> @@ -956,8 +956,8 @@ static int wled_configure(struct wled *wled, int >> version) >> struct wled_config *cfg = &wled->cfg; >> struct device *dev = wled->dev; >> const __be32 *prop_addr; >> - u32 size, val, c, string_len; >> - int rc, i, j; >> + u32 size, val, c; >> + int rc, i, j, string_len; >> >> const struct wled_u32_opts *u32_opts = NULL; >> const struct wled_u32_opts wled3_opts[] = { >> -- >> 2.7.4 >>
On Wed, 22 Jan 2020, Chen Zhou wrote: > Fixes coccicheck warning: > ./drivers/video/backlight/qcom-wled.c:1104:5-15: > WARNING: Unsigned expression compared with zero: string_len > 0 > > The unsigned variable string_len is assigned a return value from the call > to of_property_count_elems_of_size(), which may return negative error code. > > Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3") > Signed-off-by: Chen Zhou <chenzhou10@huawei.com> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > > changes in v2: > - fix commit message description. > > --- > drivers/video/backlight/qcom-wled.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks.
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index d46052d..3d276b3 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -956,8 +956,8 @@ static int wled_configure(struct wled *wled, int version) struct wled_config *cfg = &wled->cfg; struct device *dev = wled->dev; const __be32 *prop_addr; - u32 size, val, c, string_len; - int rc, i, j; + u32 size, val, c; + int rc, i, j, string_len; const struct wled_u32_opts *u32_opts = NULL; const struct wled_u32_opts wled3_opts[] = {
Fixes coccicheck warning: ./drivers/video/backlight/qcom-wled.c:1104:5-15: WARNING: Unsigned expression compared with zero: string_len > 0 The unsigned variable string_len is assigned a return value from the call to of_property_count_elems_of_size(), which may return negative error code. Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3") Signed-off-by: Chen Zhou <chenzhou10@huawei.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- changes in v2: - fix commit message description. --- drivers/video/backlight/qcom-wled.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)