| Message ID | 20200310063817.3344712-5-bjorn.andersson@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | remoteproc: Panic handling | expand |
On Mon, Mar 09, 2020 at 11:38:17PM -0700, Bjorn Andersson wrote: > Make the PAS and ADSP/CDSP remoteproc drivers implement the panic > handler that will invoke a stop to prepare the remoteprocs for post > mortem debugging. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > > Change since v3: > - Change return type to unsigned long > > drivers/remoteproc/qcom_q6v5_adsp.c | 8 ++++++++ > drivers/remoteproc/qcom_q6v5_pas.c | 8 ++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c > index d5cdff942535..8f1044e8ea3b 100644 > --- a/drivers/remoteproc/qcom_q6v5_adsp.c > +++ b/drivers/remoteproc/qcom_q6v5_adsp.c > @@ -292,12 +292,20 @@ static void *adsp_da_to_va(struct rproc *rproc, u64 da, int len) > return adsp->mem_region + offset; > } > > +static unsigned long adsp_panic(struct rproc *rproc) > +{ > + struct qcom_adsp *adsp = rproc->priv; > + > + return qcom_q6v5_panic(&adsp->q6v5); > +} > + > static const struct rproc_ops adsp_ops = { > .start = adsp_start, > .stop = adsp_stop, > .da_to_va = adsp_da_to_va, > .parse_fw = qcom_register_dump_segments, > .load = adsp_load, > + .panic = adsp_panic, > }; > > static int adsp_init_clock(struct qcom_adsp *adsp, const char **clk_ids) > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index e64c268e6113..678c0ddfce96 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -243,12 +243,20 @@ static void *adsp_da_to_va(struct rproc *rproc, u64 da, int len) > return adsp->mem_region + offset; > } > > +static unsigned long adsp_panic(struct rproc *rproc) > +{ > + struct qcom_adsp *adsp = (struct qcom_adsp *)rproc->priv; Above rproc->priv is not casted but it is here... Not a problem, just consistency. Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > + > + return qcom_q6v5_panic(&adsp->q6v5); > +} > + > static const struct rproc_ops adsp_ops = { > .start = adsp_start, > .stop = adsp_stop, > .da_to_va = adsp_da_to_va, > .parse_fw = qcom_register_dump_segments, > .load = adsp_load, > + .panic = adsp_panic, > }; > > static int adsp_init_clock(struct qcom_adsp *adsp) > -- > 2.24.0 >
diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c index d5cdff942535..8f1044e8ea3b 100644 --- a/drivers/remoteproc/qcom_q6v5_adsp.c +++ b/drivers/remoteproc/qcom_q6v5_adsp.c @@ -292,12 +292,20 @@ static void *adsp_da_to_va(struct rproc *rproc, u64 da, int len) return adsp->mem_region + offset; } +static unsigned long adsp_panic(struct rproc *rproc) +{ + struct qcom_adsp *adsp = rproc->priv; + + return qcom_q6v5_panic(&adsp->q6v5); +} + static const struct rproc_ops adsp_ops = { .start = adsp_start, .stop = adsp_stop, .da_to_va = adsp_da_to_va, .parse_fw = qcom_register_dump_segments, .load = adsp_load, + .panic = adsp_panic, }; static int adsp_init_clock(struct qcom_adsp *adsp, const char **clk_ids) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index e64c268e6113..678c0ddfce96 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -243,12 +243,20 @@ static void *adsp_da_to_va(struct rproc *rproc, u64 da, int len) return adsp->mem_region + offset; } +static unsigned long adsp_panic(struct rproc *rproc) +{ + struct qcom_adsp *adsp = (struct qcom_adsp *)rproc->priv; + + return qcom_q6v5_panic(&adsp->q6v5); +} + static const struct rproc_ops adsp_ops = { .start = adsp_start, .stop = adsp_stop, .da_to_va = adsp_da_to_va, .parse_fw = qcom_register_dump_segments, .load = adsp_load, + .panic = adsp_panic, }; static int adsp_init_clock(struct qcom_adsp *adsp)
Make the PAS and ADSP/CDSP remoteproc drivers implement the panic handler that will invoke a stop to prepare the remoteprocs for post mortem debugging. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- Change since v3: - Change return type to unsigned long drivers/remoteproc/qcom_q6v5_adsp.c | 8 ++++++++ drivers/remoteproc/qcom_q6v5_pas.c | 8 ++++++++ 2 files changed, 16 insertions(+)