| Message ID | 20200313070847.1464977-2-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ALSA: compress: Add wma, alac and ape support | expand |
On Fri, 13 Mar 2020 08:08:39 +0100, Vinod Koul wrote: > > Some codec profiles were missing for WMA, like WMA9/10 lossless and > wma10 pro, so add these profiles > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > include/uapi/sound/compress_params.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h > index 9c96fb0e4d90..634daa354b58 100644 > --- a/include/uapi/sound/compress_params.h > +++ b/include/uapi/sound/compress_params.h > @@ -142,6 +142,9 @@ > #define SND_AUDIOPROFILE_WMA8 ((__u32) 0x00000002) > #define SND_AUDIOPROFILE_WMA9 ((__u32) 0x00000004) > #define SND_AUDIOPROFILE_WMA10 ((__u32) 0x00000008) > +#define SND_AUDIOPROFILE_WMA9_PRO ((__u32) 0x00000010) > +#define SND_AUDIOPROFILE_WMA9_LOSSLESS ((__u32) 0x00000011) > +#define SND_AUDIOPROFILE_WMA10_LOSSLESS ((__u32) 0x00000012) Are the profiles are bit flags, or they are just enums? All other definitions are set as if bit flags. thanks, Takashi
On 13-03-20, 08:22, Takashi Iwai wrote: > On Fri, 13 Mar 2020 08:08:39 +0100, > Vinod Koul wrote: > > > > Some codec profiles were missing for WMA, like WMA9/10 lossless and > > wma10 pro, so add these profiles > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > include/uapi/sound/compress_params.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h > > index 9c96fb0e4d90..634daa354b58 100644 > > --- a/include/uapi/sound/compress_params.h > > +++ b/include/uapi/sound/compress_params.h > > @@ -142,6 +142,9 @@ > > #define SND_AUDIOPROFILE_WMA8 ((__u32) 0x00000002) > > #define SND_AUDIOPROFILE_WMA9 ((__u32) 0x00000004) > > #define SND_AUDIOPROFILE_WMA10 ((__u32) 0x00000008) > > +#define SND_AUDIOPROFILE_WMA9_PRO ((__u32) 0x00000010) > > +#define SND_AUDIOPROFILE_WMA9_LOSSLESS ((__u32) 0x00000011) > > +#define SND_AUDIOPROFILE_WMA10_LOSSLESS ((__u32) 0x00000012) > > Are the profiles are bit flags, or they are just enums? > All other definitions are set as if bit flags. Yup, sorry missed that, will revise Thanks
diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h index 9c96fb0e4d90..634daa354b58 100644 --- a/include/uapi/sound/compress_params.h +++ b/include/uapi/sound/compress_params.h @@ -142,6 +142,9 @@ #define SND_AUDIOPROFILE_WMA8 ((__u32) 0x00000002) #define SND_AUDIOPROFILE_WMA9 ((__u32) 0x00000004) #define SND_AUDIOPROFILE_WMA10 ((__u32) 0x00000008) +#define SND_AUDIOPROFILE_WMA9_PRO ((__u32) 0x00000010) +#define SND_AUDIOPROFILE_WMA9_LOSSLESS ((__u32) 0x00000011) +#define SND_AUDIOPROFILE_WMA10_LOSSLESS ((__u32) 0x00000012) #define SND_AUDIOMODE_WMA_LEVEL1 ((__u32) 0x00000001) #define SND_AUDIOMODE_WMA_LEVEL2 ((__u32) 0x00000002)
Some codec profiles were missing for WMA, like WMA9/10 lossless and wma10 pro, so add these profiles Signed-off-by: Vinod Koul <vkoul@kernel.org> --- include/uapi/sound/compress_params.h | 3 +++ 1 file changed, 3 insertions(+)