| Message ID | 20200509075654.175002-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1ea34b2988554af8a83a44a0a8e5aaa9e5a60c64 |
| Headers | show |
| Series | [-next] bus: mhi: core: Fix some error return code | expand |
On 0509, Wei Yongjun wrote: > Fix to return negative error code from the error handling case > instead of 0 in mhi_init_dev_ctxt() and mhi_driver_probe(). > > Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > drivers/bus/mhi/core/init.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c > index eb2ab058a01d..1f8c82603179 100644 > --- a/drivers/bus/mhi/core/init.c > +++ b/drivers/bus/mhi/core/init.c > @@ -291,6 +291,7 @@ int mhi_init_dev_ctxt(struct mhi_controller *mhi_cntrl) > } > > /* Setup cmd context */ > + ret = -ENOMEM; > mhi_ctxt->cmd_ctxt = mhi_alloc_coherent(mhi_cntrl, > sizeof(*mhi_ctxt->cmd_ctxt) * > NR_OF_CMD_RINGS, > @@ -1100,6 +1101,7 @@ static int mhi_driver_probe(struct device *dev) > } > } > > + ret = -EINVAL; > if (dl_chan) { > /* > * If channel supports LPM notifications then status_cb should > > >
Hello guys,
some nitpicking ...
the prefered kernalstyle is:
if (condition)
set error_code
do something
from what i can see it is
set error_code
if (condition)
jm2c
re,
wh
On Mon, May 11, 2020 at 02:26:10PM +0000, Walter Harms wrote: > Hello guys, > some nitpicking ... > the prefered kernalstyle is: > > if (condition) > set error_code > do something > > from what i can see it is > > set error_code > if (condition) > There are multiple error paths which share the same error code. So I don't see any benefit of setting same error code in all the paths. The recommended style makes perfect sense for an error path which has a unique error code but not for the above. Thanks, Mani > jm2c > re, > wh > > ________________________________________ > Von: kernel-janitors-owner@vger.kernel.org <kernel-janitors-owner@vger.kernel.org> im Auftrag von Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Gesendet: Montag, 11. Mai 2020 12:31:24 > An: Wei Yongjun > Cc: Hemant Kumar; Jeffrey Hugo; Greg Kroah-Hartman; Sujeev Dias; Siddartha Mohanadoss; linux-arm-msm@vger.kernel.org; kernel-janitors@vger.kernel.org; Hulk Robot > Betreff: Re: [PATCH -next] bus: mhi: core: Fix some error return code > > On 0509, Wei Yongjun wrote: > > Fix to return negative error code from the error handling case > > instead of 0 in mhi_init_dev_ctxt() and mhi_driver_probe(). > > > > Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations") > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Thanks, > Mani > > > --- > > drivers/bus/mhi/core/init.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c > > index eb2ab058a01d..1f8c82603179 100644 > > --- a/drivers/bus/mhi/core/init.c > > +++ b/drivers/bus/mhi/core/init.c > > @@ -291,6 +291,7 @@ int mhi_init_dev_ctxt(struct mhi_controller *mhi_cntrl) > > } > > > > /* Setup cmd context */ > > + ret = -ENOMEM; > > mhi_ctxt->cmd_ctxt = mhi_alloc_coherent(mhi_cntrl, > > sizeof(*mhi_ctxt->cmd_ctxt) * > > NR_OF_CMD_RINGS, > > @@ -1100,6 +1101,7 @@ static int mhi_driver_probe(struct device *dev) > > } > > } > > > > + ret = -EINVAL; > > if (dl_chan) { > > /* > > * If channel supports LPM notifications then status_cb should > > > > > >
On Mon, May 11, 2020 at 02:26:10PM +0000, Walter Harms wrote: > Hello guys, > some nitpicking ... > the prefered kernalstyle is: > > if (condition) > set error_code > do something > > from what i can see it is > > set error_code > if (condition) There isn't a prefered style. Both are accepted. Most people have a personal preference, but there isn't an official preference. regards, dan carpenter
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c index eb2ab058a01d..1f8c82603179 100644 --- a/drivers/bus/mhi/core/init.c +++ b/drivers/bus/mhi/core/init.c @@ -291,6 +291,7 @@ int mhi_init_dev_ctxt(struct mhi_controller *mhi_cntrl) } /* Setup cmd context */ + ret = -ENOMEM; mhi_ctxt->cmd_ctxt = mhi_alloc_coherent(mhi_cntrl, sizeof(*mhi_ctxt->cmd_ctxt) * NR_OF_CMD_RINGS, @@ -1100,6 +1101,7 @@ static int mhi_driver_probe(struct device *dev) } } + ret = -EINVAL; if (dl_chan) { /* * If channel supports LPM notifications then status_cb should
Fix to return negative error code from the error handling case instead of 0 in mhi_init_dev_ctxt() and mhi_driver_probe(). Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/bus/mhi/core/init.c | 2 ++ 1 file changed, 2 insertions(+)