| Message ID | 20200517115410.3374-3-eli@rje.li (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/3] dt-bindings: arm: qcom: Add sm6125 SoC and xiaomi,willow | expand |
On Sun 17 May 04:54 PDT 2020, Eli Riggs wrote: > Adds initial device tree for Xiaomi Redmi Note 8T, codename xiaomi-willow. > It uses the sm6125 SoC. Currently only boots into initrd shell over UART. > Requires appended DTB with qcom,board-id = <0x22 0x0> and > qcom,msm-id = <0x18a 0x10000> to actually boot. > If I read this correctly you need to supply board-id and msm-id in order to be able to get this booting? Even though we don't like them, I would prefer if you just add them in the dts file, in this patch. > Signed-off-by: Eli Riggs <eli@rje.li> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/sm6125-xiaomi-willow.dts | 19 +++++++++++++++++++ > 2 files changed, 20 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index cc103f7020fd6..060aa98200e47 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -22,6 +22,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sm6125-xiaomi-willow.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8150-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb > diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts > new file mode 100644 > index 0000000000000..444b32ccb9d48 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts > @@ -0,0 +1,19 @@ > +// SPDX-License-Identifier: GPL-2.0-only Please make this GPL/BSD dual license. Apart from these few remarks your patches looks good, looking forward to see more of this platform! Regards, Bjorn > +// Copyright (c) 2020, Eli Riggs <eli@rje.li> > + > +/dts-v1/; > + > +#include "sm6125.dtsi" > + > +/ { > + model = "Xiaomi Redmi Note 8T"; > + compatible = "xiaomi,willow", "qcom,sm6125"; > + > + aliases { > + serial0 = &qupv3_se4_2uart; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > +}; > -- > 2.20.1 >
On Mon, 18 May 2020 23:11:14 -0700 Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > On Sun 17 May 04:54 PDT 2020, Eli Riggs wrote: > > > Adds initial device tree for Xiaomi Redmi Note 8T, codename > > xiaomi-willow. It uses the sm6125 SoC. Currently only boots into > > initrd shell over UART. Requires appended DTB with qcom,board-id = > > <0x22 0x0> and qcom,msm-id = <0x18a 0x10000> to actually boot. > > > > If I read this correctly you need to supply board-id and msm-id in > order to be able to get this booting? > > Even though we don't like them, I would prefer if you just add them in > the dts file, in this patch. Yes, AFAICT the bootloader iterates over the appended DTBs and will only boot if it finds one with those matching properties. > > dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb diff --git > > a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts > > b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts new file mode > > 100644 index 0000000000000..444b32ccb9d48 --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts > > @@ -0,0 +1,19 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > Please make this GPL/BSD dual license. > > Apart from these few remarks your patches looks good, looking forward > to see more of this platform! > > Regards, > Bjorn OK, thanks!
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index cc103f7020fd6..060aa98200e47 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -22,6 +22,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb +dtb-$(CONFIG_ARCH_QCOM) += sm6125-xiaomi-willow.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8150-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts new file mode 100644 index 0000000000000..444b32ccb9d48 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts @@ -0,0 +1,19 @@ +// SPDX-License-Identifier: GPL-2.0-only +// Copyright (c) 2020, Eli Riggs <eli@rje.li> + +/dts-v1/; + +#include "sm6125.dtsi" + +/ { + model = "Xiaomi Redmi Note 8T"; + compatible = "xiaomi,willow", "qcom,sm6125"; + + aliases { + serial0 = &qupv3_se4_2uart; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; +};
Adds initial device tree for Xiaomi Redmi Note 8T, codename xiaomi-willow. It uses the sm6125 SoC. Currently only boots into initrd shell over UART. Requires appended DTB with qcom,board-id = <0x22 0x0> and qcom,msm-id = <0x18a 0x10000> to actually boot. Signed-off-by: Eli Riggs <eli@rje.li> --- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm6125-xiaomi-willow.dts | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm6125-xiaomi-willow.dts