| Message ID | 20200521052728.2141377-1-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a76f274182f054481182c81cd62bb8794a5450a6 |
| Headers | show |
| Series | clk: qcom: gcc: Fix parent for gpll0_out_even | expand |
On Wed 20 May 22:27 PDT 2020, Vinod Koul wrote: > Documentation says that gpll0 is parent of gpll0_out_even, somehow > driver coded that as bi_tcxo, so fix it > > Fixes: 2a1d7eb854bb ("clk: qcom: gcc: Add global clock controller driver for SM8150") > Reported-by: Jonathan Marek <jonathan@marek.ca> > Signed-off-by: Vinod Koul <vkoul@kernel.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/clk/qcom/gcc-sm8150.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c > index 2bc08e7125bf..72524cf11048 100644 > --- a/drivers/clk/qcom/gcc-sm8150.c > +++ b/drivers/clk/qcom/gcc-sm8150.c > @@ -76,8 +76,7 @@ static struct clk_alpha_pll_postdiv gpll0_out_even = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gpll0_out_even", > .parent_data = &(const struct clk_parent_data){ > - .fw_name = "bi_tcxo", > - .name = "bi_tcxo", > + .hw = &gpll0.clkr.hw, > }, > .num_parents = 1, > .ops = &clk_trion_pll_postdiv_ops, > -- > 2.25.4 >
Quoting Vinod Koul (2020-05-20 22:27:28) > Documentation says that gpll0 is parent of gpll0_out_even, somehow > driver coded that as bi_tcxo, so fix it > > Fixes: 2a1d7eb854bb ("clk: qcom: gcc: Add global clock controller driver for SM8150") > Reported-by: Jonathan Marek <jonathan@marek.ca> > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- Applied to clk-fixes
diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c index 2bc08e7125bf..72524cf11048 100644 --- a/drivers/clk/qcom/gcc-sm8150.c +++ b/drivers/clk/qcom/gcc-sm8150.c @@ -76,8 +76,7 @@ static struct clk_alpha_pll_postdiv gpll0_out_even = { .clkr.hw.init = &(struct clk_init_data){ .name = "gpll0_out_even", .parent_data = &(const struct clk_parent_data){ - .fw_name = "bi_tcxo", - .name = "bi_tcxo", + .hw = &gpll0.clkr.hw, }, .num_parents = 1, .ops = &clk_trion_pll_postdiv_ops,
Documentation says that gpll0 is parent of gpll0_out_even, somehow driver coded that as bi_tcxo, so fix it Fixes: 2a1d7eb854bb ("clk: qcom: gcc: Add global clock controller driver for SM8150") Reported-by: Jonathan Marek <jonathan@marek.ca> Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/clk/qcom/gcc-sm8150.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)