| Message ID | 20200522113341.7728-1-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8d9eb0d6d59a5d7028c80a30831143d3e75515a7 |
| Headers | show |
| Series | nvmem: qfprom: remove incorrect write support | expand |
Hi, On Fri, May 22, 2020 at 4:34 AM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > > qfprom has different address spaces for read and write. Reads are > always done from corrected address space, where as writes are done > on raw address space. > Writing to corrected address space is invalid and ignored, so it > does not make sense to have this support in the driver which only > supports corrected address space regions at the moment. > > Fixes: 4ab11996b489 ("nvmem: qfprom: Add Qualcomm QFPROM support.") > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > drivers/nvmem/qfprom.c | 14 -------------- > 1 file changed, 14 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c index d057f1bfb2e9..8a91717600be 100644 --- a/drivers/nvmem/qfprom.c +++ b/drivers/nvmem/qfprom.c @@ -27,25 +27,11 @@ static int qfprom_reg_read(void *context, return 0; } -static int qfprom_reg_write(void *context, - unsigned int reg, void *_val, size_t bytes) -{ - struct qfprom_priv *priv = context; - u8 *val = _val; - int i = 0, words = bytes; - - while (words--) - writeb(*val++, priv->base + reg + i++); - - return 0; -} - static struct nvmem_config econfig = { .name = "qfprom", .stride = 1, .word_size = 1, .reg_read = qfprom_reg_read, - .reg_write = qfprom_reg_write, }; static int qfprom_probe(struct platform_device *pdev)
qfprom has different address spaces for read and write. Reads are always done from corrected address space, where as writes are done on raw address space. Writing to corrected address space is invalid and ignored, so it does not make sense to have this support in the driver which only supports corrected address space regions at the moment. Fixes: 4ab11996b489 ("nvmem: qfprom: Add Qualcomm QFPROM support.") Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- drivers/nvmem/qfprom.c | 14 -------------- 1 file changed, 14 deletions(-)