From patchwork Fri Jul 31 20:30:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11695441 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B6254138C for ; Fri, 31 Jul 2020 20:30:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E39522CE3 for ; Fri, 31 Jul 2020 20:30:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DOMtOUbN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728555AbgGaUaf (ORCPT ); Fri, 31 Jul 2020 16:30:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbgGaUae (ORCPT ); Fri, 31 Jul 2020 16:30:34 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37F66C061757 for ; Fri, 31 Jul 2020 13:30:34 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id o13so16637671pgf.0 for ; Fri, 31 Jul 2020 13:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=weGaEUbWXhtvDsUwxI7WD59tut0B9ynJovlJxJPSr30=; b=DOMtOUbNIcUNnrO3luj2ZzSjClPQQp8fILqZhF9gYORl1w5I1GZP41crTq/7BfpBUq Hs6dY69mopbkiT/kmkfKf1o7gC26CYMKrr3qw3YRgtAFZGV9Bviv44lSgiBR5/GoULmb Zxz0QAKU7LETCyK+hpPPHS55c4FRj8dBzjZ/8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=weGaEUbWXhtvDsUwxI7WD59tut0B9ynJovlJxJPSr30=; b=RdUYchRr3fND7CAy1uzoSPZbjHkHaji221HvNAWm6m34cx2Ug8H+ksvum31cngspyO JVt97X8+wKwCypolYGBSMgvAdayHNMKFfn5M+eHImsi/Ew018MhXQxLV+t5HrgfocvpV s3Q2Ktu0omI14g3pFIKcrE7K8azM3IgHk3qMZcsxOpKS5RPdKs4GfGjnCBZRCVF9Mxja 18s6Al1BfuQWJv7r9Jl02HrM30Dfyi4tGWS1fsXixHz+blq3Cd92z4esnnNpiHZkORuH 344R7s7c/GrzRQ6Ws1d9XNNKh1h7iotSih5Vx1XP5HZj8CvzHjZ+ZT7ipGpy5d+zZonC mKNw== X-Gm-Message-State: AOAM531su3iGpNVCiSbkGM7weNGcPJ2VNkmx9DZXacfHhPVNO/vHRVM6 S/1jYvMxBZnQupPYwxdB5Bp6pQ== X-Google-Smtp-Source: ABdhPJx0V0bNap1eBuKoNNVtaRrVjctEyShWlRkYXMw241ck/GG/AhTKOG2YQFjq/njQ6XWUcSSI4g== X-Received: by 2002:a63:d62:: with SMTP id 34mr1677877pgn.179.1596227433581; Fri, 31 Jul 2020 13:30:33 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:42b0:34ff:fe3d:58e6]) by smtp.gmail.com with ESMTPSA id c132sm11050449pfb.112.2020.07.31.13.30.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 13:30:33 -0700 (PDT) From: Douglas Anderson To: Stephen Boyd Cc: Douglas Anderson , Andy Gross , Bjorn Andersson , Michael Turquette , Rob Herring , Taniya Das , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dt-bindings: clock: Fix YAML schemas for LPASS clocks on SC7180 Date: Fri, 31 Jul 2020 13:30:10 -0700 Message-Id: <20200731133006.1.Iee81b115f5be50d6d69500fe1bda11bba6e16143@changeid> X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6-goog MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The YAML schemas that landed forgot one clock: "bi_tcxo". Presumably the bindings were developed against the v4 version of the driver and when the ".name" was removed in v5 of the driver things broke. While touching this, add the needed includes in each example. I believe both examples are supposed to be independent of each other. Let's fix the bindings. Fixes: 381cc6f97cda ("dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7180") Signed-off-by: Douglas Anderson --- .../bindings/clock/qcom,sc7180-lpasscorecc.yaml | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7180-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7180-lpasscorecc.yaml index a838250b33e7..c54172fbf29f 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sc7180-lpasscorecc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sc7180-lpasscorecc.yaml @@ -25,10 +25,12 @@ properties: clocks: items: - description: gcc_lpass_sway clock from GCC + - description: Board XO source clock-names: items: - const: iface + - const: bi_tcxo power-domains: maxItems: 1 @@ -77,24 +79,28 @@ additionalProperties: false examples: - | + #include #include #include clock-controller@63000000 { compatible = "qcom,sc7180-lpasshm"; reg = <0x63000000 0x28>; - clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>; - clock-names = "iface"; + clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>, <&rpmhcc RPMH_CXO_CLK>; + clock-names = "iface", "bi_tcxo"; #clock-cells = <1>; #power-domain-cells = <1>; }; - | + #include + #include + #include clock-controller@62d00000 { compatible = "qcom,sc7180-lpasscorecc"; reg = <0x62d00000 0x50000>, <0x62780000 0x30000>; reg-names = "lpass_core_cc", "lpass_audio_cc"; - clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>; - clock-names = "iface"; + clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>, <&rpmhcc RPMH_CXO_CLK>; + clock-names = "iface", "bi_tcxo"; power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; #clock-cells = <1>; #power-domain-cells = <1>;