From patchwork Wed Sep 2 15:03:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11750875 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 007A814E3 for ; Wed, 2 Sep 2020 15:04:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D44C820C56 for ; Wed, 2 Sep 2020 15:04:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599059079; bh=FNfm1tmiP1SHAfynJEL7ATFOXsx4dnDu44NKhojfEPA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=T8ClhkgYIE3kT4hcP191E3ystcmwlOL9BtEHkpffMP+Drav2Tk4UVjYq7wizcaqMH +DxXvLXdytbPrBT4XcbCx8wNuI/8i1puF8CBsJ/WBFhC1iXGPv0bTFZOqS362PMzTx kAvvirZtzBY/L5FkNb2Z55fjQ/WokV7HyPAssYao= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727780AbgIBPEh (ORCPT ); Wed, 2 Sep 2020 11:04:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:41818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727818AbgIBPEa (ORCPT ); Wed, 2 Sep 2020 11:04:30 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9C637214F1; Wed, 2 Sep 2020 15:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599059069; bh=FNfm1tmiP1SHAfynJEL7ATFOXsx4dnDu44NKhojfEPA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nQQX60L2h/dw5HVupUkQlD1zgBiZVmY6Sewdlbk4yzSvBYGknX6upVlBsPtmbqrRZ jYdpNiDqbblahHoEMcAbKX1i+FaDn89u0TwxJUpqxr9gmf0BrxEqDntza3h6uxJtpX xImEZhMVLadjoDGFhceFvcH+ssVbmoKBO7PFUxuU= From: Krzysztof Kozlowski To: Michael Turquette , Stephen Boyd , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , David Lechner , Sekhar Nori , Santosh Shilimkar , Neil Armstrong , Jerome Brunet , Kevin Hilman , Martin Blumenstingl , Andy Gross , Bjorn Andersson , Maxime Ripard , Chen-Yu Tsai , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 07/10] clk: meson: Simplify with dev_err_probe() Date: Wed, 2 Sep 2020 17:03:45 +0200 Message-Id: <20200902150348.14465-7-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200902150348.14465-1-krzk@kernel.org> References: <20200902150348.14465-1-krzk@kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski Acked-by: Jerome Brunet --- drivers/clk/meson/axg-audio.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c index 53715e36326c..dc22b0c45743 100644 --- a/drivers/clk/meson/axg-audio.c +++ b/drivers/clk/meson/axg-audio.c @@ -1509,12 +1509,8 @@ static int devm_clk_get_enable(struct device *dev, char *id) int ret; clk = devm_clk_get(dev, id); - if (IS_ERR(clk)) { - ret = PTR_ERR(clk); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to get %s", id); - return ret; - } + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), "failed to get %s", id); ret = clk_prepare_enable(clk); if (ret) {