| Message ID | 20200915074816.52zphpywj4zidspk@linutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e1427f32b85010ca0c38104955e234ca89d4cee5 |
| Headers | show |
| Series | bus: mhi: Remove include of rwlock_types.h | expand |
On Tue, Sep 15, 2020 at 09:48:16AM +0200, Sebastian Andrzej Siewior wrote: > From: Clark Williams <williams@redhat.com> > > rwlock.h should not be included directly. Instead linux/splinlock.h > should be included. Including it directly will break the RT build. > > Also there is no point in including _types.h headers directly. There is > no benefit in including the type without the accessor. > > Fixes: 0cbf260820fa7 ("bus: mhi: core: Add support for registering MHI controllers") > Signed-off-by: Clark Williams <williams@redhat.com> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > include/linux/mhi.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index c4a940d989121..2b4ed30d47294 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -9,10 +9,9 @@ > #include <linux/device.h> > #include <linux/dma-direction.h> > #include <linux/mutex.h> > -#include <linux/rwlock_types.h> > #include <linux/skbuff.h> > #include <linux/slab.h> > -#include <linux/spinlock_types.h> > +#include <linux/spinlock.h> > #include <linux/wait.h> > #include <linux/workqueue.h> > > -- > 2.28.0 >
On Tue, Sep 15, 2020 at 09:48:16AM +0200, Sebastian Andrzej Siewior wrote: > From: Clark Williams <williams@redhat.com> > > rwlock.h should not be included directly. Instead linux/splinlock.h > should be included. Including it directly will break the RT build. > > Also there is no point in including _types.h headers directly. There is > no benefit in including the type without the accessor. > > Fixes: 0cbf260820fa7 ("bus: mhi: core: Add support for registering MHI controllers") > Signed-off-by: Clark Williams <williams@redhat.com> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Applied to mhi-next! Thanks, Mani > --- > include/linux/mhi.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index c4a940d989121..2b4ed30d47294 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -9,10 +9,9 @@ > #include <linux/device.h> > #include <linux/dma-direction.h> > #include <linux/mutex.h> > -#include <linux/rwlock_types.h> > #include <linux/skbuff.h> > #include <linux/slab.h> > -#include <linux/spinlock_types.h> > +#include <linux/spinlock.h> > #include <linux/wait.h> > #include <linux/workqueue.h> > > -- > 2.28.0 >
diff --git a/include/linux/mhi.h b/include/linux/mhi.h index c4a940d989121..2b4ed30d47294 100644 --- a/include/linux/mhi.h +++ b/include/linux/mhi.h @@ -9,10 +9,9 @@ #include <linux/device.h> #include <linux/dma-direction.h> #include <linux/mutex.h> -#include <linux/rwlock_types.h> #include <linux/skbuff.h> #include <linux/slab.h> -#include <linux/spinlock_types.h> +#include <linux/spinlock.h> #include <linux/wait.h> #include <linux/workqueue.h>