| Message ID | 20201204104900.1.I0a4ac2c7f4d405431cf95eb7b7c36800660516ec@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 465b13cc0ac1e792d844117636296c4359e15504 |
| Headers | show |
| Series | arm64: dts: qcom: Fix SD card vqmmc max voltage on sc7180-trogdor | expand |
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Fri, 4 Dec 2020 10:49:02 -0800 you wrote: > It never makes sense to set the IO voltage of the SD card (vqmmc) to a > voltage that's higher than the voltage of the card's main power supply > (vmmc). The card's main voltage is 2.952V on trogdor, so let's set > the max for the IO voltage to the same. > > NOTE: On Linux, this is pretty much a no-op currently. Linux already > makes an effort to match vqmmc with vmmc when running at "3.3" signal > voltage, so both before and after this change we end up running vqmmc > at 2.904V when talking to non-UHS cards. It still seems cleaner to > make it a little more correct, though. > > [...] Here is the summary with links: - arm64: dts: qcom: Fix SD card vqmmc max voltage on sc7180-trogdor https://git.kernel.org/qcom/c/465b13cc0ac1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 8ed7dd39f6e3..d76200d2b373 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -509,7 +509,7 @@ pp1800_l5c: ldo5 { vddpx_2: ppvar_l6c: ldo6 { regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <3304000>; + regulator-max-microvolt = <2952000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; };
It never makes sense to set the IO voltage of the SD card (vqmmc) to a voltage that's higher than the voltage of the card's main power supply (vmmc). The card's main voltage is 2.952V on trogdor, so let's set the max for the IO voltage to the same. NOTE: On Linux, this is pretty much a no-op currently. Linux already makes an effort to match vqmmc with vmmc when running at "3.3" signal voltage, so both before and after this change we end up running vqmmc at 2.904V when talking to non-UHS cards. It still seems cleaner to make it a little more correct, though. Also note: as per above, on Linux right now we end up running vqmmc as 2.904V even though vmmc is 2.952V. This isn't super ideal but shouldn't really hurt. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)