| Message ID | 20210109134044.144458-1-angelogioacchino.delregno@somainline.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4f2cf99d542c4070d5def1db20ce6436e5f92e53 |
| Headers | show |
| Series | drm/msm/a5xx: Allow all patchid for A540 chip | expand |
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Sat, 9 Jan 2021 14:40:44 +0100 you wrote: > On at least MSM8998 it's possible to find Adreno 540.0 and 540.1 > but I have never found any 540.2. In any case, the patchids 0-1 > for A540 are completely supported by this driver and there is no > reason to disallow probing them (as they also share the same > firmware names). > > Besides that, the patchid number is also used in the a5xx_power.c > function a540_lm_setup to disable the battery current limiter, > which makes faking the Adreno patchid to .2 (which would anyway > be sad) useless and even producing breakages. > > [...] Here is the summary with links: - drm/msm/a5xx: Allow all patchid for A540 chip https://git.kernel.org/qcom/c/4f2cf99d542c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index 76a89a8175f8..133e3c15a1b7 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -216,7 +216,7 @@ static const struct adreno_info gpulist[] = { .init = a5xx_gpu_init, .zapfw = "a530_zap.mdt", }, { - .rev = ADRENO_REV(5, 4, 0, 2), + .rev = ADRENO_REV(5, 4, 0, ANY_ID), .revn = 540, .name = "A540", .fw = {
On at least MSM8998 it's possible to find Adreno 540.0 and 540.1 but I have never found any 540.2. In any case, the patchids 0-1 for A540 are completely supported by this driver and there is no reason to disallow probing them (as they also share the same firmware names). Besides that, the patchid number is also used in the a5xx_power.c function a540_lm_setup to disable the battery current limiter, which makes faking the Adreno patchid to .2 (which would anyway be sad) useless and even producing breakages. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> --- drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)