| Message ID | 20210225103330.v2.4.I67e29f2854bad22e3581d6a6e1879b9fc8abbdea@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7822de1a2946fff2a00f161576125d551ccf945c |
| Headers | show |
| Series | [v2,1/4] arm64: dts: qcom: sc7180: trogdor: Add label to charger thermal zone | expand |
Quoting Matthias Kaehlcke (2021-02-25 10:33:37) > On trogdor the ADC thermal monitor is used for monitoring certain > device temperatures. All trogdor boards have at least a thermistor > for the charger temperature, optionally they may have others. > > Currently the ADC thermal monitor is configured to use channel 1 > for the charger temperature. Given that all trogdor boards have > the charger thermistor it makes more sense to use channel 0, > and then let boards with other thermistors use channels 1, 2, 3, > rather than 0, 2, 3. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > Changes in v2: > - patch added to the series > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index ab4efaece5cb..58e127b6ba1e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -19,7 +19,7 @@ charger_thermal: charger-thermal { > polling-delay-passive = <0>; > polling-delay = <0>; > > - thermal-sensors = <&pm6150_adc_tm 1>; > + thermal-sensors = <&pm6150_adc_tm 0>; Too bad this can't point at the sensor "config" node itself. Looks error prone! > > trips { > charger-crit { > @@ -718,8 +718,8 @@ charger-thermistor@4f { > &pm6150_adc_tm { > status = "okay"; > > - charger-thermistor@1 { > - reg = <1>; > + charger-thermistor@0 { > + reg = <0>; > io-channels = <&pm6150_adc ADC5_AMUX_THM3_100K_PU>; > qcom,ratiometric; > qcom,hw-settle-time-us = <200>;
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index ab4efaece5cb..58e127b6ba1e 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -19,7 +19,7 @@ charger_thermal: charger-thermal { polling-delay-passive = <0>; polling-delay = <0>; - thermal-sensors = <&pm6150_adc_tm 1>; + thermal-sensors = <&pm6150_adc_tm 0>; trips { charger-crit { @@ -718,8 +718,8 @@ charger-thermistor@4f { &pm6150_adc_tm { status = "okay"; - charger-thermistor@1 { - reg = <1>; + charger-thermistor@0 { + reg = <0>; io-channels = <&pm6150_adc ADC5_AMUX_THM3_100K_PU>; qcom,ratiometric; qcom,hw-settle-time-us = <200>;
On trogdor the ADC thermal monitor is used for monitoring certain device temperatures. All trogdor boards have at least a thermistor for the charger temperature, optionally they may have others. Currently the ADC thermal monitor is configured to use channel 1 for the charger temperature. Given that all trogdor boards have the charger thermistor it makes more sense to use channel 0, and then let boards with other thermistors use channels 1, 2, 3, rather than 0, 2, 3. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- Changes in v2: - patch added to the series arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)