| Message ID | 20210228123652.134511-1-konrad.dybcio@somainline.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4a9d36b0610aa7034340e976652e5b43320dd7c5 |
| Headers | show |
| Series | drm/msm/adreno: a5xx_power: Don't apply A540 lm_setup to other GPUs | expand |
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Sun, 28 Feb 2021 13:36:51 +0100 you wrote: > While passing the A530-specific lm_setup func to A530 and A540 > to !A530 was fine back when only these two were supported, it > certainly is not a good idea to send A540 specifics to smaller > GPUs like A508 and friends. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > > [...] Here is the summary with links: - drm/msm/adreno: a5xx_power: Don't apply A540 lm_setup to other GPUs https://git.kernel.org/qcom/c/4a9d36b0610a You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/gpu/drm/msm/adreno/a5xx_power.c b/drivers/gpu/drm/msm/adreno/a5xx_power.c index f176a6f3eff6..e58670a61df4 100644 --- a/drivers/gpu/drm/msm/adreno/a5xx_power.c +++ b/drivers/gpu/drm/msm/adreno/a5xx_power.c @@ -304,7 +304,7 @@ int a5xx_power_init(struct msm_gpu *gpu) /* Set up the limits management */ if (adreno_is_a530(adreno_gpu)) a530_lm_setup(gpu); - else + else if (adreno_is_a540(adreno_gpu)) a540_lm_setup(gpu); /* Set up SP/TP power collpase */
While passing the A530-specific lm_setup func to A530 and A540 to !A530 was fine back when only these two were supported, it certainly is not a good idea to send A540 specifics to smaller GPUs like A508 and friends. Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> --- drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)