| Message ID | 20210317164239.1007776-1-robdclark@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7ad48d27a2846bfda29214fb454d001c3e02b9e7 |
| Headers | show |
| Series | drm/msm: Ratelimit invalid-fence message | expand |
Hi, On Wed, Mar 17, 2021 at 9:40 AM Rob Clark <robdclark@gmail.com> wrote: > > From: Rob Clark <robdclark@chromium.org> > > We have seen a couple cases where low memory situations cause something > bad to happen, followed by a flood of these messages obscuring the root > cause. Lets ratelimit the dmesg spam so that next time it happens we > don't loose the kernel traces leading up to this. s/loose/lose > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- > drivers/gpu/drm/msm/msm_fence.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Wed, 17 Mar 2021 09:42:39 -0700 you wrote: > From: Rob Clark <robdclark@chromium.org> > > We have seen a couple cases where low memory situations cause something > bad to happen, followed by a flood of these messages obscuring the root > cause. Lets ratelimit the dmesg spam so that next time it happens we > don't loose the kernel traces leading up to this. > > [...] Here is the summary with links: - drm/msm: Ratelimit invalid-fence message https://git.kernel.org/qcom/c/7ad48d27a284 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/gpu/drm/msm/msm_fence.c b/drivers/gpu/drm/msm/msm_fence.c index ad2703698b05..cd59a5918038 100644 --- a/drivers/gpu/drm/msm/msm_fence.c +++ b/drivers/gpu/drm/msm/msm_fence.c @@ -45,7 +45,7 @@ int msm_wait_fence(struct msm_fence_context *fctx, uint32_t fence, int ret; if (fence > fctx->last_fence) { - DRM_ERROR("%s: waiting on invalid fence: %u (of %u)\n", + DRM_ERROR_RATELIMITED("%s: waiting on invalid fence: %u (of %u)\n", fctx->name, fence, fctx->last_fence); return -EINVAL; }