From patchwork Tue Mar 30 02:53:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 12171549 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42B06C433E4 for ; Tue, 30 Mar 2021 02:55:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06165619C7 for ; Tue, 30 Mar 2021 02:55:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231465AbhC3Cyx (ORCPT ); Mon, 29 Mar 2021 22:54:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231318AbhC3CyX (ORCPT ); Mon, 29 Mar 2021 22:54:23 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7845DC061764 for ; Mon, 29 Mar 2021 19:54:23 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so6921082pjv.1 for ; Mon, 29 Mar 2021 19:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qYK7VrB9zh1nJosxOHMeXf6pgnTeHfrprZk+pogrvOE=; b=Gc6dqK9kmETo+Nhx6WAnosO6l6Pe4N4Cqli441GiQUT9ff2Xr0mlCXlLX6zzUM2cd4 LjzpG4qVSmYxPdvz0fL9cz8HRyyWHusIDXOzBiqGI/fX0TePOdFugaUwLbb39DagvxDI PyF2+19s9Frn5Yq4n6ToLHNOkTbxE9nBksZv8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qYK7VrB9zh1nJosxOHMeXf6pgnTeHfrprZk+pogrvOE=; b=AVy3Hl9BzA95TuEYaypDFsmcv4XIKpqHhtWV/dZXDNd4L74jdbWSzpKixPe6ep6qxn YnBFo0CPor7Aa5he3+IB4z1pJBH+Fz0Ka+mOYFSjhKmQiqEuce/8x8vFs8FpR8uZ3tpF b2IWuFKv522D0MDMnukdS9WwiSNHgpnpjSuRWQjK0ePEHpoT/q1v55JSpXbjyQ6/tvjb 6aZvENG3Be0A7BGK+VVfEQrj6SrbBgyc24jqxklszAIiXYehkusdbw1PseS4oEz7lCgK p/iV6yQYC9pHPOmc1U4ZbMzddXz3E8VLsy+ZH/9Z9qyR9ZT2LQFnzWTCXvmYm1lZc1+F kXOQ== X-Gm-Message-State: AOAM530RF7k3iBwdrNLuy+sJjF4j37J0WDSaWNfTzd0amfY/jY+GBIOQ UIzhGBKQzaE37Vmt/fBieoaTzA== X-Google-Smtp-Source: ABdhPJzp+H901r/w9Tl3yZlkxjUAYJrtNugSXQZRWimDt36JIwcL8mivHva4TYJaIp+QJ1HcRxCFSg== X-Received: by 2002:a17:90a:9a91:: with SMTP id e17mr2109663pjp.218.1617072863117; Mon, 29 Mar 2021 19:54:23 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:f599:1ca7:742d:6b50]) by smtp.gmail.com with ESMTPSA id t17sm19152706pgk.25.2021.03.29.19.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Mar 2021 19:54:22 -0700 (PDT) From: Douglas Anderson To: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg Cc: Bjorn Andersson , Stephen Boyd , Maarten Lankhorst , robdclark@chromium.org, Stanislav Lisovskiy , linux-arm-msm@vger.kernel.org, Steev Klimaszewski , Linus W , Douglas Anderson , Daniel Vetter , David Airlie , Robert Foss , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 13/14] drm/bridge: ti-sn65dsi86: Print an error if we fallback to panel modes Date: Mon, 29 Mar 2021 19:53:44 -0700 Message-Id: <20210329195255.v2.13.Ib4183a04e8698f60b67558f363fddbbaf33dd445@changeid> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog In-Reply-To: <20210330025345.3980086-1-dianders@chromium.org> References: <20210330025345.3980086-1-dianders@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Now that we can properly read the EDID for modes there should be no reason to fallback to the fixed modes that our downstream panel driver provides us. Let's make that clear by: - Putting an error message in the logs if we fall back. - Putting a comment in saying what's going on. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 92498900c58d..20c3b13939c2 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -318,6 +318,13 @@ static int ti_sn_bridge_connector_get_modes(struct drm_connector *connector) return num; } + /* + * Ideally this should never happen and we could remove the fallback + * but let's preserve old behavior. + */ + DRM_DEV_ERROR(pdata->dev, + "Failed to read EDID; falling back to panel modes"); + exit: return drm_panel_get_modes(pdata->panel, connector); }