| Message ID | 20210409004945.56776-1-cuibixuan@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | usb: dwc3: qcom: Fixed an issue that the ret value is incorrect in dwc3_qcom_probe() | expand |
On Fri, Apr 09, 2021 at 08:49:45AM +0800, Bixuan Cui wrote: > There is a error message after devm_ioremap_resource failed, and the ret > is needs to be obtained through PTR_ERR(qcom->qscratch_base). > We need to move the dev_err() downwards to ensure that the ret value is > correct. > > Fixes: a4333c3a6ba9 ('usb: dwc3: Add Qualcomm DWC3 glue driver') > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> > --- > drivers/usb/dwc3/dwc3-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index e37cc58dfa55..4716ca8c753d 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -774,8 +774,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > > qcom->qscratch_base = devm_ioremap_resource(dev, parent_res); > if (IS_ERR(qcom->qscratch_base)) { > - dev_err(dev, "failed to map qscratch, err=%d\n", ret); > ret = PTR_ERR(qcom->qscratch_base); > + dev_err(dev, "failed to map qscratch, err=%d\n", ret); But this error message can be removed altogether as devm_ioremap_resource() reports it already. Thanks, Mani > goto clk_disable; > } > > -- > 2.17.1 >
On 2021/4/9 18:00, Manivannan Sadhasivam wrote: > But this error message can be removed altogether as devm_ioremap_resource() > reports it already. Thank you for your reply. I'll revise it. Thanks, Bixuan Cui
diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index e37cc58dfa55..4716ca8c753d 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -774,8 +774,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev) qcom->qscratch_base = devm_ioremap_resource(dev, parent_res); if (IS_ERR(qcom->qscratch_base)) { - dev_err(dev, "failed to map qscratch, err=%d\n", ret); ret = PTR_ERR(qcom->qscratch_base); + dev_err(dev, "failed to map qscratch, err=%d\n", ret); goto clk_disable; }
There is a error message after devm_ioremap_resource failed, and the ret is needs to be obtained through PTR_ERR(qcom->qscratch_base). We need to move the dev_err() downwards to ensure that the ret value is correct. Fixes: a4333c3a6ba9 ('usb: dwc3: Add Qualcomm DWC3 glue driver') Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> --- drivers/usb/dwc3/dwc3-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)