| Message ID | 20210517095415.3626-1-wsj20369@163.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [RESEND,v2] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN | expand |
On 2021-05-17 02:54 AM, Shujun Wang wrote: > From: Jarvis Jiang <jarvis.w.jiang@gmail.com> > > According to MHI v1.1 specification, change the channel name of T99W175 > from "AT" to "DUN" (Dial-up networking) for both channel 32 and 33, > so that the channels can be bound to the Qcom WWAN control driver, and > device node such as /dev/wwan0p3AT will be generated, which is very > useful > for debugging modem > > Fixes: aac426562f56 ("bus: mhi: pci_generic: Introduce Foxconn T99W175 > support") > Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com> > Signed-off-by: Shujun Wang <wsj20369@163.com> Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org> > --- > > v2: Add: Fixes: aac426562f56 > > drivers/bus/mhi/pci_generic.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/mhi/pci_generic.c > b/drivers/bus/mhi/pci_generic.c > index 7c810f02a2ef..8c7f6576e421 100644 > --- a/drivers/bus/mhi/pci_generic.c > +++ b/drivers/bus/mhi/pci_generic.c > @@ -311,8 +311,8 @@ static const struct mhi_channel_config > mhi_foxconn_sdx55_channels[] = { > MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1), > MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0), > MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0), > - MHI_CHANNEL_CONFIG_UL(32, "AT", 32, 0), > - MHI_CHANNEL_CONFIG_DL(33, "AT", 32, 0), > + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0), > + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0), > MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2), > MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3), > }; Thanks, Bhaumik --- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
At 2021-05-18 02:01:10, "Bhaumik Bhatt" <bbhatt@codeaurora.org> wrote: >On 2021-05-17 02:54 AM, Shujun Wang wrote: >> From: Jarvis Jiang <jarvis.w.jiang@gmail.com> >> >> According to MHI v1.1 specification, change the channel name of T99W175 >> from "AT" to "DUN" (Dial-up networking) for both channel 32 and 33, >> so that the channels can be bound to the Qcom WWAN control driver, and >> device node such as /dev/wwan0p3AT will be generated, which is very >> useful >> for debugging modem >> >> Fixes: aac426562f56 ("bus: mhi: pci_generic: Introduce Foxconn T99W175 >> support") >> Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com> >> Signed-off-by: Shujun Wang <wsj20369@163.com> > >Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org> Hi Bhaumik, Thanks a lot. >> --- >> >> v2: Add: Fixes: aac426562f56 >> >> drivers/bus/mhi/pci_generic.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/bus/mhi/pci_generic.c >> b/drivers/bus/mhi/pci_generic.c >> index 7c810f02a2ef..8c7f6576e421 100644 >> --- a/drivers/bus/mhi/pci_generic.c >> +++ b/drivers/bus/mhi/pci_generic.c >> @@ -311,8 +311,8 @@ static const struct mhi_channel_config >> mhi_foxconn_sdx55_channels[] = { >> MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1), >> MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0), >> MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0), >> - MHI_CHANNEL_CONFIG_UL(32, "AT", 32, 0), >> - MHI_CHANNEL_CONFIG_DL(33, "AT", 32, 0), >> + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0), >> + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0), >> MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2), >> MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3), >> }; > >Thanks, >Bhaumik >--- >The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >Forum, >a Linux Foundation Collaborative Project
diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c index 7c810f02a2ef..8c7f6576e421 100644 --- a/drivers/bus/mhi/pci_generic.c +++ b/drivers/bus/mhi/pci_generic.c @@ -311,8 +311,8 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = { MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1), MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0), MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0), - MHI_CHANNEL_CONFIG_UL(32, "AT", 32, 0), - MHI_CHANNEL_CONFIG_DL(33, "AT", 32, 0), + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0), + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0), MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2), MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3), };