diff mbox series

[-next,resend] perf: qcom: Remove redundant dev_err call in qcom_l3_cache_pmu_probe()

Message ID 20210608084816.1046485-1-chenxiaosong2@huawei.com (mailing list archive)
State Not Applicable, archived
Headers show
Series [-next,resend] perf: qcom: Remove redundant dev_err call in qcom_l3_cache_pmu_probe() | expand

Commit Message

ChenXiaoSong June 8, 2021, 8:48 a.m. UTC
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
---
 drivers/perf/qcom_l3_pmu.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Will Deacon June 8, 2021, 1:21 p.m. UTC | #1
On Tue, 8 Jun 2021 16:48:16 +0800, ChenXiaoSong wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Applied to will (for-next/perf), thanks!

[1/1] perf: qcom: Remove redundant dev_err call in qcom_l3_cache_pmu_probe()
      https://git.kernel.org/will/c/5ca54404e68d

Cheers,
diff mbox series

Patch

diff --git a/drivers/perf/qcom_l3_pmu.c b/drivers/perf/qcom_l3_pmu.c
index 081273543c6b..c76f6f21d2a8 100644
--- a/drivers/perf/qcom_l3_pmu.c
+++ b/drivers/perf/qcom_l3_pmu.c
@@ -767,10 +767,8 @@  static int qcom_l3_cache_pmu_probe(struct platform_device *pdev)
 
 	memrc = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	l3pmu->regs = devm_ioremap_resource(&pdev->dev, memrc);
-	if (IS_ERR(l3pmu->regs)) {
-		dev_err(&pdev->dev, "Can't map PMU @%pa\n", &memrc->start);
+	if (IS_ERR(l3pmu->regs))
 		return PTR_ERR(l3pmu->regs);
-	}
 
 	qcom_l3_cache__init(l3pmu);