| Message ID | 20210616005843.79579-4-konrad.dybcio@somainline.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/6] arm64: dts: qcom: sm8250-edo: Add hardware keys | expand |
On Tue 15 Jun 19:58 CDT 2021, Konrad Dybcio wrote: > Enabling the hardware thankfully comes down to a simple status = "okay". > We assume that the firmware is provided by the Linux distribution, as it's > signed and needs to come from the stock Android. > Are you okay with the default firmware paths? Or perhaps would it be better to shove them into qcom/sm8250/sony/<some-identifier>/* to avoid moving them later? Regards, Bjorn > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > --- > arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi > index 0d7e3dbb12b1..82ae246694ad 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi > @@ -118,6 +118,10 @@ ramoops@ffc00000 { > }; > }; > > +&adsp { > + status = "okay"; > +}; > + > &apps_rsc { > pm8150-rpmh-regulators { > compatible = "qcom,pm8150-rpmh-regulators"; > @@ -410,6 +414,10 @@ vreg_l7f_1p8: ldo7 { > }; > }; > > +&cdsp { > + status = "okay"; > +}; > + > &i2c1 { > status = "okay"; > clock-frequency = <400000>; > @@ -516,6 +524,10 @@ &sdhc_2 { > no-emmc; > }; > > +&slpi { > + status = "okay"; > +}; > + > &tlmm { > gpio-reserved-ranges = <40 4>, <52 4>; > > -- > 2.32.0 >
> Are you okay with the default firmware paths? Or perhaps would it be > better to shove them into qcom/sm8250/sony/<some-identifier>/* to avoid > moving them later? Since we have to either symlink or copy the binaries from the device Linux is running on to stay clear wrt proprietary blobs licensing, the default path is fine, as there won't be any other firmware there. If it turns out we have a better way of managing this, one can always send a patch changing it. Konrad
diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi index 0d7e3dbb12b1..82ae246694ad 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi @@ -118,6 +118,10 @@ ramoops@ffc00000 { }; }; +&adsp { + status = "okay"; +}; + &apps_rsc { pm8150-rpmh-regulators { compatible = "qcom,pm8150-rpmh-regulators"; @@ -410,6 +414,10 @@ vreg_l7f_1p8: ldo7 { }; }; +&cdsp { + status = "okay"; +}; + &i2c1 { status = "okay"; clock-frequency = <400000>; @@ -516,6 +524,10 @@ &sdhc_2 { no-emmc; }; +&slpi { + status = "okay"; +}; + &tlmm { gpio-reserved-ranges = <40 4>, <52 4>;
Enabling the hardware thankfully comes down to a simple status = "okay". We assume that the firmware is provided by the Linux distribution, as it's signed and needs to come from the stock Android. Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> --- arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)