From patchwork Fri Jun 18 03:31:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Davey X-Patchwork-Id: 12330043 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4472BC48BE5 for ; Fri, 18 Jun 2021 03:32:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F2A86128B for ; Fri, 18 Jun 2021 03:32:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232173AbhFRDeO (ORCPT ); Thu, 17 Jun 2021 23:34:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232166AbhFRDeM (ORCPT ); Thu, 17 Jun 2021 23:34:12 -0400 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [IPv6:2001:df5:b000:5::4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3140C061767 for ; Thu, 17 Jun 2021 20:32:01 -0700 (PDT) Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id D7B1A83640; Fri, 18 Jun 2021 15:31:58 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1623987118; bh=+SDIAl1yRq88xHUi/034WTzhHZGtGTRjCc92oLsrTe8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ErU/mSfM/Do/OekKIY1oCEGtlelwYFSIp/RuF70STJgT6ONzlM+1oxQaaL3ylPElf v6txtRWXlRAddYW9wLgpUZNauKf6hEtdiZb0rGCiXP6+Lk+SQdWFUSh75AlGAnAxjF h4+pdBDjFQ3g4Vt1JxRTZxN2QmUX4pZDtiSv4Z6bUIBUZMedkAGH8/66gRm0IwD0It jBAt3uqqFkg/RQ68TYbepZEltyeb1/74NKJ2g0CbrPBGKtoMBkY0Q47OAhFi9AjHb0 bYK1oTEydXbFvRS3ZkEKfLVfPj91KEjkE9qyuLrVCp6qgXC9a2y7QNQmXkczA8f+aG 7OqJ0TeNG2lfA== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Fri, 18 Jun 2021 15:31:58 +1200 Received: from pauld-dl.ws.atlnz.lc (pauld-dl.ws.atlnz.lc [10.33.23.37]) by pat.atlnz.lc (Postfix) with ESMTP id 92BFC13EEAF; Fri, 18 Jun 2021 15:31:58 +1200 (NZST) Received: by pauld-dl.ws.atlnz.lc (Postfix, from userid 1684) id 8BD9E1E0550; Fri, 18 Jun 2021 15:31:58 +1200 (NZST) From: Paul Davey To: Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Davey Subject: [PATCH 1/2] bus: mhi: Fix pm_state conversion to string Date: Fri, 18 Jun 2021 15:31:31 +1200 Message-Id: <20210618033132.24839-2-paul.davey@alliedtelesis.co.nz> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210618033132.24839-1-paul.davey@alliedtelesis.co.nz> References: <20210618033132.24839-1-paul.davey@alliedtelesis.co.nz> MIME-Version: 1.0 X-SEG-SpamProfiler-Analysis: v=2.3 cv=IOh89TnG c=1 sm=1 tr=0 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=r6YtysWOX24A:10 a=SQbU7SH2vTJutzk7rhIA:9 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On big endian architectures the mhi debugfs files which report pm state give "Invalid State" for all states. Fix to_mhi_pm_state_str by using a local unsigned long as an intemediate to pass the state to find_last_bit to avoid endianness issues with cast from enum mhi_pm_state * to unsigned long *. Signed-off-by: Paul Davey Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi/core/init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c index c81b377fca8f..87cc0c449078 100644 --- a/drivers/bus/mhi/core/init.c +++ b/drivers/bus/mhi/core/init.c @@ -79,7 +79,8 @@ static const char * const mhi_pm_state_str[] = { const char *to_mhi_pm_state_str(enum mhi_pm_state state) { - int index = find_last_bit((unsigned long *)&state, 32); + unsigned long tmp = state; + int index = find_last_bit((unsigned long *)&tmp, 32); if (index >= ARRAY_SIZE(mhi_pm_state_str)) return "Invalid State";