diff mbox series

[v2,1/3] dt-bindings: soc: qcom: aoss: Add SC8180X and generic compatible

Message ID 20210709174142.1274554-2-bjorn.andersson@linaro.org (mailing list archive)
State Accepted
Headers show
Series dt-bindings: soc: qcom: aoss: Support sc8180x and convert to YAML | expand

Commit Message

Bjorn Andersson July 9, 2021, 5:41 p.m. UTC
Add a generic compatible for all versions of the AOSS QMP to the
binding, in order to allow a single implementation for them and then add
a specific compatible for the Qualcomm SC8180x platform.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---

Changes since v1:
- Mention the generic compatible in $subject and message.

 Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Rob Herring July 15, 2021, 4:13 p.m. UTC | #1
On Fri, Jul 09, 2021 at 10:41:40AM -0700, Bjorn Andersson wrote:
> Add a generic compatible for all versions of the AOSS QMP to the
> binding, in order to allow a single implementation for them and then add
> a specific compatible for the Qualcomm SC8180x platform.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> 
> Changes since v1:
> - Mention the generic compatible in $subject and message.
> 
>  Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> index 783dc81b0f26..3747032311a4 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> @@ -18,10 +18,13 @@ power-domains.
>  	Definition: must be one of:
>  		    "qcom,sc7180-aoss-qmp"
>  		    "qcom,sc7280-aoss-qmp"
> +		    "qcom,sc8180x-aoss-qmp"
>  		    "qcom,sdm845-aoss-qmp"
>  		    "qcom,sm8150-aoss-qmp"
>  		    "qcom,sm8250-aoss-qmp"
>  		    "qcom,sm8350-aoss-qmp"
> +		    and:
> +		    "qcom,aoss-qmp"

Are you going to update all the dts files to add this?

Rob
Rob Herring July 15, 2021, 4:13 p.m. UTC | #2
On Fri, 09 Jul 2021 10:41:40 -0700, Bjorn Andersson wrote:
> Add a generic compatible for all versions of the AOSS QMP to the
> binding, in order to allow a single implementation for them and then add
> a specific compatible for the Qualcomm SC8180x platform.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> 
> Changes since v1:
> - Mention the generic compatible in $subject and message.
> 
>  Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
index 783dc81b0f26..3747032311a4 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
@@ -18,10 +18,13 @@  power-domains.
 	Definition: must be one of:
 		    "qcom,sc7180-aoss-qmp"
 		    "qcom,sc7280-aoss-qmp"
+		    "qcom,sc8180x-aoss-qmp"
 		    "qcom,sdm845-aoss-qmp"
 		    "qcom,sm8150-aoss-qmp"
 		    "qcom,sm8250-aoss-qmp"
 		    "qcom,sm8350-aoss-qmp"
+		    and:
+		    "qcom,aoss-qmp"
 
 - reg:
 	Usage: required
@@ -70,7 +73,7 @@  The following example represents the AOSS side-channel message RAM and the
 mechanism exposing the power-domains, as found in SDM845.
 
   aoss_qmp: qmp@c300000 {
-	  compatible = "qcom,sdm845-aoss-qmp";
+	  compatible = "qcom,sdm845-aoss-qmp", "qcom,aoss-qmp";
 	  reg = <0x0c300000 0x100000>;
 	  interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
 	  mboxes = <&apss_shared 0>;