| Message ID | 20210811235253.924867-2-robdclark@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/msm+ti-sn65dsi86: Fix NO_CONNECTOR fallout | expand |
Quoting Rob Clark (2021-08-11 16:52:47) > From: Rob Clark <robdclark@chromium.org> > > If we created our own connector because the driver does not support the > NO_CONNECTOR flag, we don't want the downstream bridge to *also* create > a connector. And if this driver did pass the NO_CONNECTOR flag (and we > supported that mode) this would change nothing. > > Fixes: 4e5763f03e10 ("drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge") > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- Thanks for saving me the packaging effort. Reported-by: Stephen Boyd <swboyd@chromium.org> Tested-by: Stephen Boyd <swboyd@chromium.org>
Hi Rob, Thank you for the patch. On Wed, Aug 11, 2021 at 04:52:47PM -0700, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > If we created our own connector because the driver does not support the > NO_CONNECTOR flag, we don't want the downstream bridge to *also* create > a connector. And if this driver did pass the NO_CONNECTOR flag (and we > supported that mode) this would change nothing. > > Fixes: 4e5763f03e10 ("drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge") > Signed-off-by: Rob Clark <robdclark@chromium.org> Makes complete sense. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 9bf889302bcc..5d3b30b2f547 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -736,6 +736,9 @@ static int ti_sn_bridge_attach(struct drm_bridge *bridge, > } > pdata->dsi = dsi; > > + /* We never want the next bridge to *also* create a connector: */ > + flags |= DRM_BRIDGE_ATTACH_NO_CONNECTOR; > + > /* Attach the next bridge */ > ret = drm_bridge_attach(bridge->encoder, pdata->next_bridge, > &pdata->bridge, flags);
Hi, On Wed, Aug 11, 2021 at 4:51 PM Rob Clark <robdclark@gmail.com> wrote: > > From: Rob Clark <robdclark@chromium.org> > > If we created our own connector because the driver does not support the > NO_CONNECTOR flag, we don't want the downstream bridge to *also* create > a connector. And if this driver did pass the NO_CONNECTOR flag (and we > supported that mode) this would change nothing. > > Fixes: 4e5763f03e10 ("drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge") > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Douglas Anderson <dianders@chromium.org> Tested-by: Douglas Anderson <dianders@chromium.org> I'm going to apply this one to drm-misc/drm-misc-next and push since it's a fix and we're before -rc6, then I'll take a look at the later patches in the series. -Doug
On Thu, Aug 12, 2021 at 9:55 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Wed, Aug 11, 2021 at 4:51 PM Rob Clark <robdclark@gmail.com> wrote: > > > > From: Rob Clark <robdclark@chromium.org> > > > > If we created our own connector because the driver does not support the > > NO_CONNECTOR flag, we don't want the downstream bridge to *also* create > > a connector. And if this driver did pass the NO_CONNECTOR flag (and we > > supported that mode) this would change nothing. > > > > Fixes: 4e5763f03e10 ("drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge") > > Signed-off-by: Rob Clark <robdclark@chromium.org> > > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 +++ > > 1 file changed, 3 insertions(+) > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > Tested-by: Douglas Anderson <dianders@chromium.org> > > I'm going to apply this one to drm-misc/drm-misc-next and push since > it's a fix and we're before -rc6, then I'll take a look at the later > patches in the series. > Thanks.. this is the only one with some urgency, the rest can wait until next cycle. (And the bridge vs msm patches can land independently, I've tested the different possible combinations) BR, -R
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 9bf889302bcc..5d3b30b2f547 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -736,6 +736,9 @@ static int ti_sn_bridge_attach(struct drm_bridge *bridge, } pdata->dsi = dsi; + /* We never want the next bridge to *also* create a connector: */ + flags |= DRM_BRIDGE_ATTACH_NO_CONNECTOR; + /* Attach the next bridge */ ret = drm_bridge_attach(bridge->encoder, pdata->next_bridge, &pdata->bridge, flags);