| Message ID | 20210924025255.853906-1-bjorn.andersson@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: c630: Move panel to aux-bus | expand |
On Thu, Sep 23, 2021 at 09:52:55PM -0500, Bjorn Andersson wrote: > With the newly introduced aux-bus under the TI SN65DSI86 the panel > node should be described as a child instead of a standalone node, move > it there. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 27 +++++++++---------- > 1 file changed, 13 insertions(+), 14 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > index bd22352b6c7a..4818ca6d820d 100644 > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > @@ -56,20 +56,6 @@ mode { > }; > }; > > - panel { > - compatible = "boe,nv133fhm-n61"; > - no-hpd; > - backlight = <&backlight>; There is some prerequisite change for this patch? I do not find this backlight node on v5.15-rc, neither linux-next. Shawn > - > - ports { > - port { > - panel_in_edp: endpoint { > - remote-endpoint = <&sn65dsi86_out>; > - }; > - }; > - }; > - }; > - > /* Reserved memory changes for IPA */ > reserved-memory { > wlan_msa_mem: memory@8c400000 { > @@ -441,6 +427,19 @@ sn65dsi86_out: endpoint { > }; > }; > }; > + > + aux-bus { > + panel: panel { > + compatible = "boe,nv133fhm-n61"; > + backlight = <&backlight>; > + > + port { > + panel_in_edp: endpoint { > + remote-endpoint = <&sn65dsi86_out>; > + }; > + }; > + }; > + }; > }; > }; > > -- > 2.32.0 >
On Sun 26 Sep 01:07 CDT 2021, Shawn Guo wrote: > On Thu, Sep 23, 2021 at 09:52:55PM -0500, Bjorn Andersson wrote: > > With the newly introduced aux-bus under the TI SN65DSI86 the panel > > node should be described as a child instead of a standalone node, move > > it there. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > --- > > .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 27 +++++++++---------- > > 1 file changed, 13 insertions(+), 14 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > > index bd22352b6c7a..4818ca6d820d 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > > @@ -56,20 +56,6 @@ mode { > > }; > > }; > > > > - panel { > > - compatible = "boe,nv133fhm-n61"; > > - no-hpd; > > - backlight = <&backlight>; > > There is some prerequisite change for this patch? I do not find this > backlight node on v5.15-rc, neither linux-next. > Seems I had this and the backlight addition patch in the wrong order in my local tree. Let's see if we can land the backlight support and then I'll repost this. Thanks, Bjorn > Shawn > > > - > > - ports { > > - port { > > - panel_in_edp: endpoint { > > - remote-endpoint = <&sn65dsi86_out>; > > - }; > > - }; > > - }; > > - }; > > - > > /* Reserved memory changes for IPA */ > > reserved-memory { > > wlan_msa_mem: memory@8c400000 { > > @@ -441,6 +427,19 @@ sn65dsi86_out: endpoint { > > }; > > }; > > }; > > + > > + aux-bus { > > + panel: panel { > > + compatible = "boe,nv133fhm-n61"; > > + backlight = <&backlight>; > > + > > + port { > > + panel_in_edp: endpoint { > > + remote-endpoint = <&sn65dsi86_out>; > > + }; > > + }; > > + }; > > + }; > > }; > > }; > > > > -- > > 2.32.0 > >
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts index bd22352b6c7a..4818ca6d820d 100644 --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts @@ -56,20 +56,6 @@ mode { }; }; - panel { - compatible = "boe,nv133fhm-n61"; - no-hpd; - backlight = <&backlight>; - - ports { - port { - panel_in_edp: endpoint { - remote-endpoint = <&sn65dsi86_out>; - }; - }; - }; - }; - /* Reserved memory changes for IPA */ reserved-memory { wlan_msa_mem: memory@8c400000 { @@ -441,6 +427,19 @@ sn65dsi86_out: endpoint { }; }; }; + + aux-bus { + panel: panel { + compatible = "boe,nv133fhm-n61"; + backlight = <&backlight>; + + port { + panel_in_edp: endpoint { + remote-endpoint = <&sn65dsi86_out>; + }; + }; + }; + }; }; };
With the newly introduced aux-bus under the TI SN65DSI86 the panel node should be described as a child instead of a standalone node, move it there. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 27 +++++++++---------- 1 file changed, 13 insertions(+), 14 deletions(-)