| Message ID | 20210928112945.25310-1-stephan@gerhold.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 483de2b44cd3a168458f8f9ff237e78a434729bc |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: pm8916: Remove wrong reg-names for rtc@6000 | expand |
On Tue, 28 Sep 2021 13:29:43 +0200, Stephan Gerhold wrote: > While removing the size from the "reg" properties in pm8916.dtsi, > commit bd6429e81010 ("ARM64: dts: qcom: Remove size elements from > pmic reg properties") mistakenly also removed the second register > address for the rtc@6000 device. That one did not represent the size > of the register region but actually the address of the second "alarm" > register region of the rtc@6000 device. > > [...] Applied, thanks! [1/3] arm64: dts: qcom: pm8916: Remove wrong reg-names for rtc@6000 commit: 483de2b44cd3a168458f8f9ff237e78a434729bc [2/3] arm64: dts: qcom: pm8916: Add pm8941-misc extcon for USB detection commit: f5d7bca55425c8611e6cfa3f236d1f56031920e8 [3/3] arm64: dts: qcom: msm8916-longcheer-l8150: Use &pm8916_usbin extcon commit: b30cad26d8030bddeb0ee2373b6d4c1440ffb1a3 Best regards,
Hello: This series was applied to qcom/linux.git (refs/heads/for-next): On Tue, 28 Sep 2021 13:29:43 +0200 you wrote: > While removing the size from the "reg" properties in pm8916.dtsi, > commit bd6429e81010 ("ARM64: dts: qcom: Remove size elements from > pmic reg properties") mistakenly also removed the second register > address for the rtc@6000 device. That one did not represent the size > of the register region but actually the address of the second "alarm" > register region of the rtc@6000 device. > > [...] Here is the summary with links: - [1/3] arm64: dts: qcom: pm8916: Remove wrong reg-names for rtc@6000 https://git.kernel.org/qcom/c/483de2b44cd3 - [2/3] arm64: dts: qcom: pm8916: Add pm8941-misc extcon for USB detection https://git.kernel.org/qcom/c/f5d7bca55425 - [3/3] arm64: dts: qcom: msm8916-longcheer-l8150: Use &pm8916_usbin extcon https://git.kernel.org/qcom/c/b30cad26d803 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi index f931cb0de231..42180f1b5dbb 100644 --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi @@ -86,7 +86,6 @@ adc-chan@f { rtc@6000 { compatible = "qcom,pm8941-rtc"; reg = <0x6000>; - reg-names = "rtc", "alarm"; interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; };
While removing the size from the "reg" properties in pm8916.dtsi, commit bd6429e81010 ("ARM64: dts: qcom: Remove size elements from pmic reg properties") mistakenly also removed the second register address for the rtc@6000 device. That one did not represent the size of the register region but actually the address of the second "alarm" register region of the rtc@6000 device. Now there are "reg-names" for two "reg" elements, but there is actually only one "reg" listed. Since the DT schema for "qcom,pm8941-rtc" only expects one "reg" element anyway, just drop the "reg-names" entirely to fix this. Fixes: bd6429e81010 ("ARM64: dts: qcom: Remove size elements from pmic reg properties") Signed-off-by: Stephan Gerhold <stephan@gerhold.net> --- arch/arm64/boot/dts/qcom/pm8916.dtsi | 1 - 1 file changed, 1 deletion(-)