| Message ID | 20210928200811.22059-1-liumh1@shanghaitech.edu.cn (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [-next,-v2] ./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c | expand |
On Tue 28 Sep 13:08 PDT 2021, Mianhan Liu wrote: If you run a "git log --oneline -- drivers/bluetooth/btqcomsmd.c" you will see that the appropriate prefix would be "Bluetooth: btqcomsmd: " In other words, a better $subject would be: [PATCH v2] Bluetooth: btqcomsmd: remove superfluous includes > btqcomsmd.c hasn't use any macro or function declared in linux/of.h > and linux/slab.h. > Thus, these files can be removed from btqcomsmd.c safely without > affecting the compilation of the ./drivers/bluetooth module > > Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn> > > --- Here is an excellent place to state "Changes since v1" and mention that you no longer remove btqca.h and you added your S-o-b. > drivers/bluetooth/btqcomsmd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c > index 2acb719e5..e556d96a4 100644 > --- a/drivers/bluetooth/btqcomsmd.c > +++ b/drivers/bluetooth/btqcomsmd.c > @@ -5,9 +5,7 @@ > */ > > #include <linux/module.h> > -#include <linux/slab.h> > #include <linux/rpmsg.h> > -#include <linux/of.h> > This looks reasonable. Regards, Bjorn > #include <linux/soc/qcom/wcnss_ctrl.h> > #include <linux/platform_device.h> > -- > 2.25.1 > >
diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c index 2acb719e5..e556d96a4 100644 --- a/drivers/bluetooth/btqcomsmd.c +++ b/drivers/bluetooth/btqcomsmd.c @@ -5,9 +5,7 @@ */ #include <linux/module.h> -#include <linux/slab.h> #include <linux/rpmsg.h> -#include <linux/of.h> #include <linux/soc/qcom/wcnss_ctrl.h> #include <linux/platform_device.h>
btqcomsmd.c hasn't use any macro or function declared in linux/of.h and linux/slab.h. Thus, these files can be removed from btqcomsmd.c safely without affecting the compilation of the ./drivers/bluetooth module Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn> --- drivers/bluetooth/btqcomsmd.c | 2 -- 1 file changed, 2 deletions(-)