| Message ID | 20211020155604.1374530-1-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | phy: qcom-qmp: another fix for the sc8180x PCIe definition | expand |
On Wed 20 Oct 08:56 PDT 2021, Dmitry Baryshkov wrote: > Commit f839f14e24f2 ("phy: qcom-qmp: Add sc8180x PCIe support") added > SC8180X PCIe tables, but used sm8250_qmp_pcie_serdes_tbl as a serdes > table because of the copy paste error. Commit bfccd9a71a08 ("phy: > qcom-qmp: Fix sc8180x PCIe definition") corrected part of this mistake > by pointing serdes_tbl to sc8180x_qmp_pcie_serdes_tbl, however the > serdes_tbl_num field was not updated to use sc8180x table. So let's now > fix the serdes_tbl_num field too. > > Fixes: bfccd9a71a08 ("phy: qcom-qmp: Fix sc8180x PCIe definition") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Damn it...my eyes doesn't like these solid chunks of text. Thanks Dmitry. Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > index f14032170b1c..06b04606dd7e 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -3632,7 +3632,7 @@ static const struct qmp_phy_cfg sc8180x_pciephy_cfg = { > .nlanes = 1, > > .serdes_tbl = sc8180x_qmp_pcie_serdes_tbl, > - .serdes_tbl_num = ARRAY_SIZE(sm8250_qmp_pcie_serdes_tbl), > + .serdes_tbl_num = ARRAY_SIZE(sc8180x_qmp_pcie_serdes_tbl), > .tx_tbl = sc8180x_qmp_pcie_tx_tbl, > .tx_tbl_num = ARRAY_SIZE(sc8180x_qmp_pcie_tx_tbl), > .rx_tbl = sc8180x_qmp_pcie_rx_tbl, > -- > 2.33.0 >
On 20-10-21, 18:56, Dmitry Baryshkov wrote: > Commit f839f14e24f2 ("phy: qcom-qmp: Add sc8180x PCIe support") added > SC8180X PCIe tables, but used sm8250_qmp_pcie_serdes_tbl as a serdes > table because of the copy paste error. Commit bfccd9a71a08 ("phy: > qcom-qmp: Fix sc8180x PCIe definition") corrected part of this mistake > by pointing serdes_tbl to sc8180x_qmp_pcie_serdes_tbl, however the > serdes_tbl_num field was not updated to use sc8180x table. So let's now > fix the serdes_tbl_num field too. Applied, thanks
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index f14032170b1c..06b04606dd7e 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -3632,7 +3632,7 @@ static const struct qmp_phy_cfg sc8180x_pciephy_cfg = { .nlanes = 1, .serdes_tbl = sc8180x_qmp_pcie_serdes_tbl, - .serdes_tbl_num = ARRAY_SIZE(sm8250_qmp_pcie_serdes_tbl), + .serdes_tbl_num = ARRAY_SIZE(sc8180x_qmp_pcie_serdes_tbl), .tx_tbl = sc8180x_qmp_pcie_tx_tbl, .tx_tbl_num = ARRAY_SIZE(sc8180x_qmp_pcie_tx_tbl), .rx_tbl = sc8180x_qmp_pcie_rx_tbl,
Commit f839f14e24f2 ("phy: qcom-qmp: Add sc8180x PCIe support") added SC8180X PCIe tables, but used sm8250_qmp_pcie_serdes_tbl as a serdes table because of the copy paste error. Commit bfccd9a71a08 ("phy: qcom-qmp: Fix sc8180x PCIe definition") corrected part of this mistake by pointing serdes_tbl to sc8180x_qmp_pcie_serdes_tbl, however the serdes_tbl_num field was not updated to use sc8180x table. So let's now fix the serdes_tbl_num field too. Fixes: bfccd9a71a08 ("phy: qcom-qmp: Fix sc8180x PCIe definition") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)