| Message ID | 20211031020715.21636-4-shawn.guo@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | A few smd-rpm clock driver cleanups | expand |
On Sat 30 Oct 21:07 CDT 2021, Shawn Guo wrote: > The buffered clock binary value handling added by commit 36354c32bd76 > ("clk: qcom: smd-rpm: Add .recalc_rate hook for clk_smd_rpm_branch_ops") > is redundant, because buffered clock is branch type, and the binary > value handling for branch clock has been handled by > clk_smd_rpm_prepare/unprepare functions. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/clk/qcom/clk-smd-rpm.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c > index dd3d373a1309..ea28e45ca371 100644 > --- a/drivers/clk/qcom/clk-smd-rpm.c > +++ b/drivers/clk/qcom/clk-smd-rpm.c > @@ -189,10 +189,6 @@ static int clk_smd_rpm_set_rate_active(struct clk_smd_rpm *r, > .value = cpu_to_le32(DIV_ROUND_UP(rate, 1000)), /* to kHz */ > }; > > - /* Buffered clock needs a binary value */ > - if (r->rpm_res_type == QCOM_SMD_RPM_CLK_BUF_A) > - req.value = cpu_to_le32(!!req.value); > - > return qcom_rpm_smd_write(r->rpm, QCOM_SMD_RPM_ACTIVE_STATE, > r->rpm_res_type, r->rpm_clk_id, &req, > sizeof(req)); > @@ -207,10 +203,6 @@ static int clk_smd_rpm_set_rate_sleep(struct clk_smd_rpm *r, > .value = cpu_to_le32(DIV_ROUND_UP(rate, 1000)), /* to kHz */ > }; > > - /* Buffered clock needs a binary value */ > - if (r->rpm_res_type == QCOM_SMD_RPM_CLK_BUF_A) > - req.value = cpu_to_le32(!!req.value); > - > return qcom_rpm_smd_write(r->rpm, QCOM_SMD_RPM_SLEEP_STATE, > r->rpm_res_type, r->rpm_clk_id, &req, > sizeof(req)); > -- > 2.17.1 >
Quoting Bjorn Andersson (2021-12-06 07:26:44) > On Sat 30 Oct 21:07 CDT 2021, Shawn Guo wrote: > > > The buffered clock binary value handling added by commit 36354c32bd76 > > ("clk: qcom: smd-rpm: Add .recalc_rate hook for clk_smd_rpm_branch_ops") > > is redundant, because buffered clock is branch type, and the binary > > value handling for branch clock has been handled by > > clk_smd_rpm_prepare/unprepare functions. > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Does that mean you picked it up? Or you want me to pick it up?
On Mon 06 Dec 14:21 PST 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-12-06 07:26:44) > > On Sat 30 Oct 21:07 CDT 2021, Shawn Guo wrote: > > > > > The buffered clock binary value handling added by commit 36354c32bd76 > > > ("clk: qcom: smd-rpm: Add .recalc_rate hook for clk_smd_rpm_branch_ops") > > > is redundant, because buffered clock is branch type, and the binary > > > value handling for branch clock has been handled by > > > clk_smd_rpm_prepare/unprepare functions. > > > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > Does that mean you picked it up? Or you want me to pick it up? It meant that I reviewed the patch, but as it's not a regression I then went on to pick it up for clk-next - there should be a "thank you" from a few minutes ago. I'll ensure to include a note for you in the future when it could go in either branch. Regards, Bjorn
Quoting Bjorn Andersson (2021-12-06 14:36:48) > On Mon 06 Dec 14:21 PST 2021, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2021-12-06 07:26:44) > > > On Sat 30 Oct 21:07 CDT 2021, Shawn Guo wrote: > > > > > > > The buffered clock binary value handling added by commit 36354c32bd76 > > > > ("clk: qcom: smd-rpm: Add .recalc_rate hook for clk_smd_rpm_branch_ops") > > > > is redundant, because buffered clock is branch type, and the binary > > > > value handling for branch clock has been handled by > > > > clk_smd_rpm_prepare/unprepare functions. > > > > > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > > > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > > > Does that mean you picked it up? Or you want me to pick it up? > > It meant that I reviewed the patch, but as it's not a regression I then > went on to pick it up for clk-next - there should be a "thank you" from > a few minutes ago. > > I'll ensure to include a note for you in the future when it could go in > either branch. > Ok, thanks.
diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c index dd3d373a1309..ea28e45ca371 100644 --- a/drivers/clk/qcom/clk-smd-rpm.c +++ b/drivers/clk/qcom/clk-smd-rpm.c @@ -189,10 +189,6 @@ static int clk_smd_rpm_set_rate_active(struct clk_smd_rpm *r, .value = cpu_to_le32(DIV_ROUND_UP(rate, 1000)), /* to kHz */ }; - /* Buffered clock needs a binary value */ - if (r->rpm_res_type == QCOM_SMD_RPM_CLK_BUF_A) - req.value = cpu_to_le32(!!req.value); - return qcom_rpm_smd_write(r->rpm, QCOM_SMD_RPM_ACTIVE_STATE, r->rpm_res_type, r->rpm_clk_id, &req, sizeof(req)); @@ -207,10 +203,6 @@ static int clk_smd_rpm_set_rate_sleep(struct clk_smd_rpm *r, .value = cpu_to_le32(DIV_ROUND_UP(rate, 1000)), /* to kHz */ }; - /* Buffered clock needs a binary value */ - if (r->rpm_res_type == QCOM_SMD_RPM_CLK_BUF_A) - req.value = cpu_to_le32(!!req.value); - return qcom_rpm_smd_write(r->rpm, QCOM_SMD_RPM_SLEEP_STATE, r->rpm_res_type, r->rpm_clk_id, &req, sizeof(req));
The buffered clock binary value handling added by commit 36354c32bd76 ("clk: qcom: smd-rpm: Add .recalc_rate hook for clk_smd_rpm_branch_ops") is redundant, because buffered clock is branch type, and the binary value handling for branch clock has been handled by clk_smd_rpm_prepare/unprepare functions. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> --- drivers/clk/qcom/clk-smd-rpm.c | 8 -------- 1 file changed, 8 deletions(-)