| Message ID | 20211104170835.1993686-1-bjorn.andersson@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | pinctrl: qcom: sm8350: Correct UFS and SDC offsets | expand |
On 11/4/21 7:08 PM, Bjorn Andersson wrote: > The downstream TLMM binding covers a group of TLMM-related hardware > blocks, but the upstream binding only captures the particular block > related to controlling the TLMM pins from an OS. In the translation of > the driver from downstream, the offset of 0x100000 was lost for the UFS > and SDC pingroups. > > Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver") > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c > index 4d8f8636c2b3..1c042d39380c 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sm8350.c > +++ b/drivers/pinctrl/qcom/pinctrl-sm8350.c > @@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = { > [200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _), > [201] = PINGROUP(201, _, _, _, _, _, _, _, _, _), > [202] = PINGROUP(202, _, _, _, _, _, _, _, _, _), > - [203] = UFS_RESET(ufs_reset, 0x1d8000), > - [204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6), > - [205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3), > - [206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0), > + [203] = UFS_RESET(ufs_reset, 0xd8000), > + [204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6), > + [205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3), > + [206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0), > }; > > static const struct msm_gpio_wakeirq_map sm8350_pdc_map[] = { > Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> -- Best wishes, Vladimir
On 04-11-21, 10:08, Bjorn Andersson wrote: > The downstream TLMM binding covers a group of TLMM-related hardware > blocks, but the upstream binding only captures the particular block > related to controlling the TLMM pins from an OS. In the translation of > the driver from downstream, the offset of 0x100000 was lost for the UFS > and SDC pingroups. > > Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver") > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c > index 4d8f8636c2b3..1c042d39380c 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sm8350.c > +++ b/drivers/pinctrl/qcom/pinctrl-sm8350.c > @@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = { > [200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _), > [201] = PINGROUP(201, _, _, _, _, _, _, _, _, _), > [202] = PINGROUP(202, _, _, _, _, _, _, _, _, _), > - [203] = UFS_RESET(ufs_reset, 0x1d8000), > - [204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6), > - [205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3), > - [206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0), > + [203] = UFS_RESET(ufs_reset, 0xd8000), > + [204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6), > + [205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3), > + [206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0), Right, these are the offsets defined in the the documentation, sorry to have missed updating here Reviewed-by: Vinod Koul <vkoul@kernel.org>
On Thu, Nov 4, 2021 at 6:06 PM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > The downstream TLMM binding covers a group of TLMM-related hardware > blocks, but the upstream binding only captures the particular block > related to controlling the TLMM pins from an OS. In the translation of > the driver from downstream, the offset of 0x100000 was lost for the UFS > and SDC pingroups. > > Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver") > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Patch applied for fixes. Yours, Linus Walleij
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c index 4d8f8636c2b3..1c042d39380c 100644 --- a/drivers/pinctrl/qcom/pinctrl-sm8350.c +++ b/drivers/pinctrl/qcom/pinctrl-sm8350.c @@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = { [200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _), [201] = PINGROUP(201, _, _, _, _, _, _, _, _, _), [202] = PINGROUP(202, _, _, _, _, _, _, _, _, _), - [203] = UFS_RESET(ufs_reset, 0x1d8000), - [204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6), - [205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3), - [206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0), + [203] = UFS_RESET(ufs_reset, 0xd8000), + [204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6), + [205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3), + [206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0), }; static const struct msm_gpio_wakeirq_map sm8350_pdc_map[] = {
The downstream TLMM binding covers a group of TLMM-related hardware blocks, but the upstream binding only captures the particular block related to controlling the TLMM pins from an OS. In the translation of the driver from downstream, the offset of 0x100000 was lost for the UFS and SDC pingroups. Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver") Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)