| Message ID | 20211110120512.150940-1-deng.changcheng@zte.com.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [linux-next] drm/msm/dp: remove unneeded variable | expand |
Quoting cgel.zte@gmail.com (2021-11-10 04:05:12) > From: Changcheng Deng <deng.changcheng@zte.com.cn> > > Fix the following coccicheck review: > ./drivers/gpu/drm/msm/dp/dp_debug.c: Unneeded variable > > Remove unneeded variable used to store return value. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> > --- > drivers/gpu/drm/msm/dp/dp_debug.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_debug.c b/drivers/gpu/drm/msm/dp/dp_debug.c > index 2f6247e80e9d..c5c75273d1e5 100644 > --- a/drivers/gpu/drm/msm/dp/dp_debug.c > +++ b/drivers/gpu/drm/msm/dp/dp_debug.c > @@ -365,7 +365,6 @@ static const struct file_operations test_active_fops = { > > static int dp_debug_init(struct dp_debug *dp_debug, struct drm_minor *minor) Would be nice to make it void as well and then cleanup the caller. Can you do that too? > { > - int rc = 0; > struct dp_debug_private *debug = container_of(dp_debug, > struct dp_debug_private, dp_debug); >
diff --git a/drivers/gpu/drm/msm/dp/dp_debug.c b/drivers/gpu/drm/msm/dp/dp_debug.c index 2f6247e80e9d..c5c75273d1e5 100644 --- a/drivers/gpu/drm/msm/dp/dp_debug.c +++ b/drivers/gpu/drm/msm/dp/dp_debug.c @@ -365,7 +365,6 @@ static const struct file_operations test_active_fops = { static int dp_debug_init(struct dp_debug *dp_debug, struct drm_minor *minor) { - int rc = 0; struct dp_debug_private *debug = container_of(dp_debug, struct dp_debug_private, dp_debug); @@ -386,7 +385,7 @@ static int dp_debug_init(struct dp_debug *dp_debug, struct drm_minor *minor) debug->root = minor->debugfs_root; - return rc; + return 0; } struct dp_debug *dp_debug_get(struct device *dev, struct dp_panel *panel,