| Message ID | 20211208083423.22037-2-marijn.suijten@somainline.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | firmware: qcom: scm: Add IOMMU pool size and | expand |
On 12/8/21 2:34 AM, Marijn Suijten wrote: > Member assignments to qcom_scm_desc were moved into struct initializers > in 57d3b816718c ("firmware: qcom_scm: Remove thin wrappers") including > the case in qcom_scm_iommu_secure_ptbl_init, except that the - now > duplicate - assignment to desc was left in place. While not harmful, > remove this unnecessary extra reassignment. > > Fixes: 57d3b816718c ("firmware: qcom_scm: Remove thin wrappers") > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> Looks good. Reviewed-by: Alex Elder <elder@linaro.org> > --- > drivers/firmware/qcom_scm.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index 7db8066b19fd..3f67bf774821 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -749,12 +749,6 @@ int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare) > }; > int ret; > > - desc.args[0] = addr; > - desc.args[1] = size; > - desc.args[2] = spare; > - desc.arginfo = QCOM_SCM_ARGS(3, QCOM_SCM_RW, QCOM_SCM_VAL, > - QCOM_SCM_VAL); > - > ret = qcom_scm_call(__scm->dev, &desc, NULL); > > /* the pg table has been initialized already, ignore the error */ >
diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 7db8066b19fd..3f67bf774821 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -749,12 +749,6 @@ int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare) }; int ret; - desc.args[0] = addr; - desc.args[1] = size; - desc.args[2] = spare; - desc.arginfo = QCOM_SCM_ARGS(3, QCOM_SCM_RW, QCOM_SCM_VAL, - QCOM_SCM_VAL); - ret = qcom_scm_call(__scm->dev, &desc, NULL); /* the pg table has been initialized already, ignore the error */
Member assignments to qcom_scm_desc were moved into struct initializers in 57d3b816718c ("firmware: qcom_scm: Remove thin wrappers") including the case in qcom_scm_iommu_secure_ptbl_init, except that the - now duplicate - assignment to desc was left in place. While not harmful, remove this unnecessary extra reassignment. Fixes: 57d3b816718c ("firmware: qcom_scm: Remove thin wrappers") Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> --- drivers/firmware/qcom_scm.c | 6 ------ 1 file changed, 6 deletions(-)