| Message ID | 20211231094419.1941054-1-jiasheng@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | soc: qcom: rpmpd: Check for null return of devm_kcalloc | expand |
On Fri, 31 Dec 2021 17:44:19 +0800, Jiasheng Jiang wrote: > Because of the possible failure of the allocation, data->domains might > be NULL pointer and will cause the dereference of the NULL pointer > later. > Therefore, it might be better to check it and directly return -ENOMEM > without releasing data manually if fails, because the comment of the > devm_kmalloc() says "Memory allocated with this function is > automatically freed on driver detach.". > > [...] Applied, thanks! [1/1] soc: qcom: rpmpd: Check for null return of devm_kcalloc commit: 5a811126d38f9767a20cc271b34db7c8efc5a46c Best regards,
diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c index 27733b0e7fca..f4ef8a100c99 100644 --- a/drivers/soc/qcom/rpmpd.c +++ b/drivers/soc/qcom/rpmpd.c @@ -496,6 +496,9 @@ static int rpmpd_probe(struct platform_device *pdev) data->domains = devm_kcalloc(&pdev->dev, num, sizeof(*data->domains), GFP_KERNEL); + if (!data->domains) + return -ENOMEM; + data->num_domains = num; for (i = 0; i < num; i++) {
Because of the possible failure of the allocation, data->domains might be NULL pointer and will cause the dereference of the NULL pointer later. Therefore, it might be better to check it and directly return -ENOMEM without releasing data manually if fails, because the comment of the devm_kmalloc() says "Memory allocated with this function is automatically freed on driver detach.". Fixes: bbe3a66c3f5a ("soc: qcom: rpmpd: Add a Power domain driver to model corners") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/soc/qcom/rpmpd.c | 3 +++ 1 file changed, 3 insertions(+)