diff mbox series

[v4,1/4] math.h: Introduce data types for fractional numbers

Message ID 20220126135353.24007-1-andriy.shevchenko@linux.intel.com (mailing list archive)
State Not Applicable
Headers show
Series [v4,1/4] math.h: Introduce data types for fractional numbers | expand

Commit Message

Andy Shevchenko Jan. 26, 2022, 1:53 p.m. UTC
Introduce a macro to produce data types like

	struct TYPE_fract {
		__TYPE numerator;
		__TYPE denominator;
	};

to be used in the code wherever it's needed.

In the following changes convert some users to it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

May be pulled via IIO tree.

v4: no changes
v3: no changes
v2: no changes

 include/linux/math.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Andy Shevchenko Jan. 26, 2022, 2:12 p.m. UTC | #1
On Wed, Jan 26, 2022 at 03:53:50PM +0200, Andy Shevchenko wrote:
> Introduce a macro to produce data types like
> 
> 	struct TYPE_fract {
> 		__TYPE numerator;
> 		__TYPE denominator;
> 	};
> 
> to be used in the code wherever it's needed.
> 
> In the following changes convert some users to it.

The context of v4 is the dropped AFE patches.
Jonathan Cameron Jan. 30, 2022, 12:30 p.m. UTC | #2
On Wed, 26 Jan 2022 15:53:50 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Introduce a macro to produce data types like
> 
> 	struct TYPE_fract {
> 		__TYPE numerator;
> 		__TYPE denominator;
> 	};
> 
> to be used in the code wherever it's needed.
> 
> In the following changes convert some users to it.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I'm not 100% sold on this, but I'm going to give them the benefit
of the doubt as to long term usefulness and apply them.

Basically I'm taking the view Andy is often right :)

Applied to the togreg branch of iio.git and pushed out as testing
for 0-day to see if we missed anything.

Thanks,

Jonathan

> ---
> 
> May be pulled via IIO tree.
> 
> v4: no changes
> v3: no changes
> v2: no changes
> 
>  include/linux/math.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/include/linux/math.h b/include/linux/math.h
> index 53674a327e39..439b8f0b9ebd 100644
> --- a/include/linux/math.h
> +++ b/include/linux/math.h
> @@ -2,6 +2,7 @@
>  #ifndef _LINUX_MATH_H
>  #define _LINUX_MATH_H
>  
> +#include <linux/types.h>
>  #include <asm/div64.h>
>  #include <uapi/linux/kernel.h>
>  
> @@ -106,6 +107,17 @@
>  }							\
>  )
>  
> +#define __STRUCT_FRACT(type)				\
> +struct type##_fract {					\
> +	__##type numerator;				\
> +	__##type denominator;				\
> +};
> +__STRUCT_FRACT(s16)
> +__STRUCT_FRACT(u16)
> +__STRUCT_FRACT(s32)
> +__STRUCT_FRACT(u32)
> +#undef __STRUCT_FRACT
> +
>  /*
>   * Multiplies an integer by a fraction, while avoiding unnecessary
>   * overflow or loss of precision.
Andy Shevchenko Jan. 31, 2022, 10:17 a.m. UTC | #3
On Sun, Jan 30, 2022 at 12:30:47PM +0000, Jonathan Cameron wrote:
> On Wed, 26 Jan 2022 15:53:50 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> > Introduce a macro to produce data types like
> > 
> > 	struct TYPE_fract {
> > 		__TYPE numerator;
> > 		__TYPE denominator;
> > 	};
> > 
> > to be used in the code wherever it's needed.
> > 
> > In the following changes convert some users to it.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> I'm not 100% sold on this, but I'm going to give them the benefit
> of the doubt as to long term usefulness and apply them.
> 
> Basically I'm taking the view Andy is often right :)

Time will show :-)

> Applied to the togreg branch of iio.git and pushed out as testing
> for 0-day to see if we missed anything.

Thanks!
diff mbox series

Patch

diff --git a/include/linux/math.h b/include/linux/math.h
index 53674a327e39..439b8f0b9ebd 100644
--- a/include/linux/math.h
+++ b/include/linux/math.h
@@ -2,6 +2,7 @@ 
 #ifndef _LINUX_MATH_H
 #define _LINUX_MATH_H
 
+#include <linux/types.h>
 #include <asm/div64.h>
 #include <uapi/linux/kernel.h>
 
@@ -106,6 +107,17 @@ 
 }							\
 )
 
+#define __STRUCT_FRACT(type)				\
+struct type##_fract {					\
+	__##type numerator;				\
+	__##type denominator;				\
+};
+__STRUCT_FRACT(s16)
+__STRUCT_FRACT(u16)
+__STRUCT_FRACT(s32)
+__STRUCT_FRACT(u32)
+#undef __STRUCT_FRACT
+
 /*
  * Multiplies an integer by a fraction, while avoiding unnecessary
  * overflow or loss of precision.