| Message ID | 20220131161034.5.Ibaf8a803802beb089cc6266b37e6156cff3ddaec@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8fdedd6c64643884dc6bbf6d9a7aabda1713354f |
| Headers | show |
| Series | arm64: dts: qcom: sc7x80: A smattering of misc dts cleanups | expand |
On Mon, Jan 31, 2022 at 04:10:42PM -0800, Douglas Anderson wrote: > Specifying "input-enable" on a MSM GPIO is a no-op for the most > part. The only thing it really does is to explicitly force the output > of a GPIO to be disabled right at the point of a pinctrl > transition. We don't need to do this and we don't typically specify > "input-enable" unless there's a good reason to. Remove it. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index 7a987bc9b758..23e656e51904 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -534,7 +534,6 @@ sd_cd: sd-cd { sw_ctrl: sw-ctrl { pins = "gpio86"; function = "gpio"; - input-enable; bias-pull-down; }; };
Specifying "input-enable" on a MSM GPIO is a no-op for the most part. The only thing it really does is to explicitly force the output of a GPIO to be disabled right at the point of a pinctrl transition. We don't need to do this and we don't typically specify "input-enable" unless there's a good reason to. Remove it. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 - 1 file changed, 1 deletion(-)