| Message ID | 20220202132301.v3.7.Ic84bb69c45be2fccf50e3bd17b845fe20eec624c@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: dts: qcom: sc7x80: A smattering of misc dts cleanups + herobrine-rev1 | expand |
On Wed, Feb 02, 2022 at 01:23:41PM -0800, Douglas Anderson wrote: > Like dp_out, we should have defined edp_out in sc7280.dtsi so we don't > need to do this in the board files. > > Like dp_hot_plug_det, we should define edp_hot_plug_det in > sc7280.dtsi. > > We should set the default pinctrl for edp_hot_plug_det in > sc7280.dtsi. NOTE: this is _unlike_ the dp_hot_plug_det. It is > reasonable that in some boards the dedicated DP Hot Plug Detect will > not be hooked up in favor of Type C mechanisms. This is unlike eDP > where the Hot Plug Detect line (which functions as "panel ready" in > eDP) is highly likely to be used by boards. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Quoting Douglas Anderson (2022-02-02 13:23:41) > Like dp_out, we should have defined edp_out in sc7280.dtsi so we don't > need to do this in the board files. > > Like dp_hot_plug_det, we should define edp_hot_plug_det in > sc7280.dtsi. > > We should set the default pinctrl for edp_hot_plug_det in > sc7280.dtsi. NOTE: this is _unlike_ the dp_hot_plug_det. It is > reasonable that in some boards the dedicated DP Hot Plug Detect will > not be hooked up in favor of Type C mechanisms. This is unlike eDP > where the Hot Plug Detect line (which functions as "panel ready" in > eDP) is highly likely to be used by boards. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 4d5892411a38..3f9837921c17 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -3010,6 +3010,8 @@ mdss_dsi_phy: phy@ae94400 { mdss_edp: edp@aea0000 { compatible = "qcom,sc7280-edp"; + pinctrl-names = "default"; + pinctrl-0 = <&edp_hot_plug_det>; reg = <0 0xaea0000 0 0x200>, <0 0xaea0200 0 0x200>, @@ -3052,12 +3054,18 @@ mdss_edp: edp@aea0000 { ports { #address-cells = <1>; #size-cells = <0>; + port@0 { reg = <0>; edp_in: endpoint { remote-endpoint = <&dpu_intf5_out>; }; }; + + port@1 { + reg = <1>; + edp_out: endpoint { }; + }; }; edp_opp_table: opp-table { @@ -3277,6 +3285,11 @@ dp_hot_plug_det: dp-hot-plug-det { bias-disable; }; + edp_hot_plug_det: edp-hot-plug-det { + pins = "gpio60"; + function = "edp_hot"; + }; + pcie1_clkreq_n: pcie1-clkreq-n { pins = "gpio79"; function = "pcie1_clkreqn";
Like dp_out, we should have defined edp_out in sc7280.dtsi so we don't need to do this in the board files. Like dp_hot_plug_det, we should define edp_hot_plug_det in sc7280.dtsi. We should set the default pinctrl for edp_hot_plug_det in sc7280.dtsi. NOTE: this is _unlike_ the dp_hot_plug_det. It is reasonable that in some boards the dedicated DP Hot Plug Detect will not be hooked up in favor of Type C mechanisms. This is unlike eDP where the Hot Plug Detect line (which functions as "panel ready" in eDP) is highly likely to be used by boards. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Changes in v3: - ("Add edp_out port and HPD lines") new for v3. arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+)