diff mbox series

[v2,3/8] arm64: dts: qcom: msm8996-xiaomi: Drop max-microamp and vddp-ref-clk properties from QMP PHY

Message ID 20220228123019.382037-4-bhupesh.sharma@linaro.org (mailing list archive)
State Superseded
Headers show
Series Fix dtbs_check warning(s) for Qualcomm QMP PHY | expand

Commit Message

Bhupesh Sharma Feb. 28, 2022, 12:30 p.m. UTC
The following properties are not supported and causing dtbs_check
warnings.

    - vdda-phy-max-microamp
    - vdda-pll-max-microamp
    - vddp-ref-clk-max-microamp
    - vddp-ref-clk-always-on

arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dt.yaml: phy@627000:
   'vdda-phy-max-microamp', 'vddp-ref-clk-always-on', 'vddp-ref-clk-max-microamp'
    do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'

Drop them from QMP PHY nodes for 'msm8996-xiaomi' dts.

Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 5 -----
 1 file changed, 5 deletions(-)

Comments

Shawn Guo March 1, 2022, 4:22 a.m. UTC | #1
On Mon, Feb 28, 2022 at 06:00:14PM +0530, Bhupesh Sharma wrote:
> The following properties are not supported and causing dtbs_check
> warnings.
> 
>     - vdda-phy-max-microamp
>     - vdda-pll-max-microamp
>     - vddp-ref-clk-max-microamp
>     - vddp-ref-clk-always-on
> 
> arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dt.yaml: phy@627000:
>    'vdda-phy-max-microamp', 'vddp-ref-clk-always-on', 'vddp-ref-clk-max-microamp'
>     do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 
> Drop them from QMP PHY nodes for 'msm8996-xiaomi' dts.
> 
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> index 7a9fcbe9bb31..f6f6b2e89a36 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> @@ -337,12 +337,7 @@ &ufsphy {
>  	vdda-phy-supply = <&vreg_l28a_0p925>;
>  	vdda-pll-supply = <&vreg_l12a_1p8>;
>  
> -	vdda-phy-max-microamp = <18380>;
> -	vdda-pll-max-microamp = <9440>;
> -
>  	vddp-ref-clk-supply = <&vreg_l25a_1p2>;

I do not see this is supported by qmp-phy driver.  Maybe we should drop
it from bindings and clean up from DTS as well?

Shawn

> -	vddp-ref-clk-max-microamp = <100>;
> -	vddp-ref-clk-always-on;
>  };
>  
>  &venus {
> -- 
> 2.35.1
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
index 7a9fcbe9bb31..f6f6b2e89a36 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
@@ -337,12 +337,7 @@  &ufsphy {
 	vdda-phy-supply = <&vreg_l28a_0p925>;
 	vdda-pll-supply = <&vreg_l12a_1p8>;
 
-	vdda-phy-max-microamp = <18380>;
-	vdda-pll-max-microamp = <9440>;
-
 	vddp-ref-clk-supply = <&vreg_l25a_1p2>;
-	vddp-ref-clk-max-microamp = <100>;
-	vddp-ref-clk-always-on;
 };
 
 &venus {