| Message ID | 20220302225411.2456001-5-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/6] arm64: dts: qcom: msm8996: Drop flags for mdss irqs | expand |
On 3/2/2022 2:54 PM, Dmitry Baryshkov wrote: > The number of interrupt cells for the mdss interrupt controller is 1, > meaning there should only be one cell for the interrupt number, not two. > Drop the second cell containing (unused) irq flags. > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Fixes: 7c1dffd471b1 ("arm64: dts: qcom: sm8250.dtsi: add display system nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index fdaf303ba047..956848068871 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -3200,7 +3200,7 @@ mdss_mdp: mdp@ae01000 { > power-domains = <&rpmhpd SM8250_MMCX>; > > interrupt-parent = <&mdss>; > - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <0>; > > ports { > #address-cells = <1>; > @@ -3252,7 +3252,7 @@ dsi0: dsi@ae94000 { > reg-names = "dsi_ctrl"; > > interrupt-parent = <&mdss>; > - interrupts = <4 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <4>; > > clocks = <&dispcc DISP_CC_MDSS_BYTE0_CLK>, > <&dispcc DISP_CC_MDSS_BYTE0_INTF_CLK>, > @@ -3325,7 +3325,7 @@ dsi1: dsi@ae96000 { > reg-names = "dsi_ctrl"; > > interrupt-parent = <&mdss>; > - interrupts = <5 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <5>; > > clocks = <&dispcc DISP_CC_MDSS_BYTE1_CLK>, > <&dispcc DISP_CC_MDSS_BYTE1_INTF_CLK>,
On 2022-03-03 01:54:10, Dmitry Baryshkov wrote: > The number of interrupt cells for the mdss interrupt controller is 1, > meaning there should only be one cell for the interrupt number, not two. > Drop the second cell containing (unused) irq flags. > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Fixes: 7c1dffd471b1 ("arm64: dts: qcom: sm8250.dtsi: add display system nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Thanks for adding the Fixes: tag. Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index fdaf303ba047..956848068871 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -3200,7 +3200,7 @@ mdss_mdp: mdp@ae01000 { > power-domains = <&rpmhpd SM8250_MMCX>; > > interrupt-parent = <&mdss>; > - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <0>; > > ports { > #address-cells = <1>; > @@ -3252,7 +3252,7 @@ dsi0: dsi@ae94000 { > reg-names = "dsi_ctrl"; > > interrupt-parent = <&mdss>; > - interrupts = <4 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <4>; > > clocks = <&dispcc DISP_CC_MDSS_BYTE0_CLK>, > <&dispcc DISP_CC_MDSS_BYTE0_INTF_CLK>, > @@ -3325,7 +3325,7 @@ dsi1: dsi@ae96000 { > reg-names = "dsi_ctrl"; > > interrupt-parent = <&mdss>; > - interrupts = <5 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <5>; > > clocks = <&dispcc DISP_CC_MDSS_BYTE1_CLK>, > <&dispcc DISP_CC_MDSS_BYTE1_INTF_CLK>, > -- > 2.34.1 >
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index fdaf303ba047..956848068871 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -3200,7 +3200,7 @@ mdss_mdp: mdp@ae01000 { power-domains = <&rpmhpd SM8250_MMCX>; interrupt-parent = <&mdss>; - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <0>; ports { #address-cells = <1>; @@ -3252,7 +3252,7 @@ dsi0: dsi@ae94000 { reg-names = "dsi_ctrl"; interrupt-parent = <&mdss>; - interrupts = <4 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <4>; clocks = <&dispcc DISP_CC_MDSS_BYTE0_CLK>, <&dispcc DISP_CC_MDSS_BYTE0_INTF_CLK>, @@ -3325,7 +3325,7 @@ dsi1: dsi@ae96000 { reg-names = "dsi_ctrl"; interrupt-parent = <&mdss>; - interrupts = <5 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <5>; clocks = <&dispcc DISP_CC_MDSS_BYTE1_CLK>, <&dispcc DISP_CC_MDSS_BYTE1_INTF_CLK>,