| Message ID | 20220309190152.7998-4-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Multiple addition to ipq8064 dtsi | expand |
On Wed 09 Mar 13:01 CST 2022, Ansuel Smith wrote: > Add cells definition for rpm node Why do we need the cells? > and add missing regulators for the 4 > regulator present on ipq8064. There regulators are controlled by rpm and > to correctly works gsbi4_i2c require to be NEVER disabled or rpm will Are you saying "...to correctly work, gsbi4_i2c must NEVER be disabled..."? If so, that's good information, but how does it relate to this particular change? Regards, Bjorn > reject any regulator change request. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > Tested-by: Jonathan McDowell <noodles@earth.li> > --- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 36 +++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index b309bc0fbbcd..0938838a4af8 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -842,10 +842,46 @@ rpm: rpm@108000 { > clocks = <&gcc RPM_MSG_RAM_H_CLK>; > clock-names = "ram"; > > + #address-cells = <1>; > + #size-cells = <0>; > + > rpmcc: clock-controller { > compatible = "qcom,rpmcc-ipq806x", "qcom,rpmcc"; > #clock-cells = <1>; > }; > + > + smb208_regulators: regulators { > + compatible = "qcom,rpm-smb208-regulators"; > + status = "okay"; > + > + smb208_s1a: s1a { > + regulator-min-microvolt = <1050000>; > + regulator-max-microvolt = <1150000>; > + > + qcom,switch-mode-frequency = <1200000>; > + }; > + > + smb208_s1b: s1b { > + regulator-min-microvolt = <1050000>; > + regulator-max-microvolt = <1150000>; > + > + qcom,switch-mode-frequency = <1200000>; > + }; > + > + smb208_s2a: s2a { > + regulator-min-microvolt = < 800000>; > + regulator-max-microvolt = <1250000>; > + > + qcom,switch-mode-frequency = <1200000>; > + }; > + > + smb208_s2b: s2b { > + regulator-min-microvolt = < 800000>; > + regulator-max-microvolt = <1250000>; > + > + qcom,switch-mode-frequency = <1200000>; > + }; > + }; > }; > > tcsr: syscon@1a400000 { > -- > 2.34.1 >
On Tue, Apr 12, 2022 at 02:46:39PM -0500, Bjorn Andersson wrote: > On Wed 09 Mar 13:01 CST 2022, Ansuel Smith wrote: > > > Add cells definition for rpm node > > Why do we need the cells? > Mh I'm referring to address-cells and size-cells required for reg or dtb will give warnings. > > and add missing regulators for the 4 > > regulator present on ipq8064. There regulators are controlled by rpm and > > to correctly works gsbi4_i2c require to be NEVER disabled or rpm will > > Are you saying "...to correctly work, gsbi4_i2c must NEVER be disabled..."? > > If so, that's good information, but how does it relate to this > particular change? > It doesn't but since it I had many days trying to debug the regulators not working only to discover that the problem was with the pin, I thought it was a good idea to add this info. Should I just drop it or should i add some comments in the dts? > Regards, > Bjorn > > > reject any regulator change request. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > Tested-by: Jonathan McDowell <noodles@earth.li> > > --- > > arch/arm/boot/dts/qcom-ipq8064.dtsi | 36 +++++++++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > > index b309bc0fbbcd..0938838a4af8 100644 > > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > > @@ -842,10 +842,46 @@ rpm: rpm@108000 { > > clocks = <&gcc RPM_MSG_RAM_H_CLK>; > > clock-names = "ram"; > > > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > rpmcc: clock-controller { > > compatible = "qcom,rpmcc-ipq806x", "qcom,rpmcc"; > > #clock-cells = <1>; > > }; > > + > > + smb208_regulators: regulators { > > + compatible = "qcom,rpm-smb208-regulators"; > > + status = "okay"; > > + > > + smb208_s1a: s1a { > > + regulator-min-microvolt = <1050000>; > > + regulator-max-microvolt = <1150000>; > > + > > + qcom,switch-mode-frequency = <1200000>; > > + }; > > + > > + smb208_s1b: s1b { > > + regulator-min-microvolt = <1050000>; > > + regulator-max-microvolt = <1150000>; > > + > > + qcom,switch-mode-frequency = <1200000>; > > + }; > > + > > + smb208_s2a: s2a { > > + regulator-min-microvolt = < 800000>; > > + regulator-max-microvolt = <1250000>; > > + > > + qcom,switch-mode-frequency = <1200000>; > > + }; > > + > > + smb208_s2b: s2b { > > + regulator-min-microvolt = < 800000>; > > + regulator-max-microvolt = <1250000>; > > + > > + qcom,switch-mode-frequency = <1200000>; > > + }; > > + }; > > }; > > > > tcsr: syscon@1a400000 { > > -- > > 2.34.1 > >
diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi index b309bc0fbbcd..0938838a4af8 100644 --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi @@ -842,10 +842,46 @@ rpm: rpm@108000 { clocks = <&gcc RPM_MSG_RAM_H_CLK>; clock-names = "ram"; + #address-cells = <1>; + #size-cells = <0>; + rpmcc: clock-controller { compatible = "qcom,rpmcc-ipq806x", "qcom,rpmcc"; #clock-cells = <1>; }; + + smb208_regulators: regulators { + compatible = "qcom,rpm-smb208-regulators"; + status = "okay"; + + smb208_s1a: s1a { + regulator-min-microvolt = <1050000>; + regulator-max-microvolt = <1150000>; + + qcom,switch-mode-frequency = <1200000>; + }; + + smb208_s1b: s1b { + regulator-min-microvolt = <1050000>; + regulator-max-microvolt = <1150000>; + + qcom,switch-mode-frequency = <1200000>; + }; + + smb208_s2a: s2a { + regulator-min-microvolt = < 800000>; + regulator-max-microvolt = <1250000>; + + qcom,switch-mode-frequency = <1200000>; + }; + + smb208_s2b: s2b { + regulator-min-microvolt = < 800000>; + regulator-max-microvolt = <1250000>; + + qcom,switch-mode-frequency = <1200000>; + }; + }; }; tcsr: syscon@1a400000 {