| Message ID | 20220316172814.v1.1.I2deda8f2cd6adfbb525a97d8fee008a8477b7b0e@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 737f9ea6cee76fb0004c116479a9db34a67fb814 |
| Headers | show |
| Series | [v1,1/4] arm64: dts: qcom: sc7280: Rename crd to crd-r3 | expand |
Hi, On Wed, Mar 16, 2022 at 5:28 PM Matthias Kaehlcke <mka@chromium.org> wrote: > > There are multiple revisions of CRD boards. The current sc7280-crd.dts > describes revision 3 and 4 (aka CRD 1.0 and 2.0). Support for a newer > version will be added by another patch. Add the revision number to > distinguish it from the versionn. Also add the revision numbers to > the compatible string. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > > arch/arm64/boot/dts/qcom/Makefile | 2 +- > .../arm64/boot/dts/qcom/{sc7280-crd.dts => sc7280-crd-r3.dts} | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
Quoting Matthias Kaehlcke (2022-03-16 17:28:17) > There are multiple revisions of CRD boards. The current sc7280-crd.dts > describes revision 3 and 4 (aka CRD 1.0 and 2.0). Support for a newer > version will be added by another patch. Add the revision number to > distinguish it from the versionn. Also add the revision numbers to > the compatible string. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
On 3/17/2022 5:58 AM, Matthias Kaehlcke wrote: > There are multiple revisions of CRD boards. The current sc7280-crd.dts > describes revision 3 and 4 (aka CRD 1.0 and 2.0). Support for a newer > version will be added by another patch. Add the revision number to > distinguish it from the versionn. Also add the revision numbers to > the compatible string. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > Reviewed-by: Rajendra Nayak <quic_rjendra@quicinc.com>
Hello: This series was applied to qcom/linux.git (for-next) by Bjorn Andersson <bjorn.andersson@linaro.org>: On Wed, 16 Mar 2022 17:28:17 -0700 you wrote: > There are multiple revisions of CRD boards. The current sc7280-crd.dts > describes revision 3 and 4 (aka CRD 1.0 and 2.0). Support for a newer > version will be added by another patch. Add the revision number to > distinguish it from the versionn. Also add the revision numbers to > the compatible string. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > [...] Here is the summary with links: - [v1,1/4] arm64: dts: qcom: sc7280: Rename crd to crd-r3 https://git.kernel.org/qcom/c/737f9ea6cee7 - [v1,2/4] arm64: dts: qcom: sc7280: Add 'piglin' to the crd-r3 compatible strings https://git.kernel.org/qcom/c/f226c6605334 - [v1,3/4] arm64: dts: qcom: sc7280: herobrine: disable some regulators by default https://git.kernel.org/qcom/c/533ca1c3c199 - [v1,4/4] arm64: dts: qcom: sc7280: Add CRD rev5 https://git.kernel.org/qcom/c/6675ac9d0046 You are awesome, thank you!
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index f9e6343acd03..38d41b1d70ad 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -87,7 +87,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r0.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r1.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp2.dtb -dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd-r3.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-ganges-kirin.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-discovery.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-pioneer.dtb diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts similarity index 91% rename from arch/arm64/boot/dts/qcom/sc7280-crd.dts rename to arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts index e2efbdde53a3..7a028b9248c3 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts @@ -11,8 +11,8 @@ #include "sc7280-idp-ec-h1.dtsi" / { - model = "Qualcomm Technologies, Inc. sc7280 CRD platform"; - compatible = "qcom,sc7280-crd", "google,hoglin", "qcom,sc7280"; + model = "Qualcomm Technologies, Inc. sc7280 CRD platform (rev3 - 4)"; + compatible = "qcom,sc7280-crd", "google,hoglin-rev3", "google,hoglin-rev4", "qcom,sc7280"; aliases { serial0 = &uart5;
There are multiple revisions of CRD boards. The current sc7280-crd.dts describes revision 3 and 4 (aka CRD 1.0 and 2.0). Support for a newer version will be added by another patch. Add the revision number to distinguish it from the versionn. Also add the revision numbers to the compatible string. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- arch/arm64/boot/dts/qcom/Makefile | 2 +- .../arm64/boot/dts/qcom/{sc7280-crd.dts => sc7280-crd-r3.dts} | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) rename arch/arm64/boot/dts/qcom/{sc7280-crd.dts => sc7280-crd-r3.dts} (91%)