| Message ID | 20220324223331.876199-1-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f31c834d3976652753f39eb319170c8c4ac3ce55 |
| Headers | show |
| Series | arm64: dts: qcom: sc7280: Fix sar1_irq_odl node name | expand |
Hi, On Thu, Mar 24, 2022 at 3:33 PM Stephen Boyd <swboyd@chromium.org> wrote: > > This node should be named sar1-irq-odl, not sar0-irq-odl. Otherwise > we'll overwrite the settings for sar0 with what is intended for sar1, > leading to probe failures for sar1 that are quite confusing. > > Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1") > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Matthias Kaehlcke <mka@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Oops! Thanks! Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Thu, Mar 24, 2022 at 03:33:31PM -0700, Stephen Boyd wrote: > This node should be named sar1-irq-odl, not sar0-irq-odl. Otherwise > we'll overwrite the settings for sar0 with what is intended for sar1, > leading to probe failures for sar1 that are quite confusing. > > Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1") > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Matthias Kaehlcke <mka@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> Tested-by: Matthias Kaehlcke <mka@chromium.org>
Hello: This patch was applied to qcom/linux.git (for-next) by Bjorn Andersson <bjorn.andersson@linaro.org>: On Thu, 24 Mar 2022 15:33:31 -0700 you wrote: > This node should be named sar1-irq-odl, not sar0-irq-odl. Otherwise > we'll overwrite the settings for sar0 with what is intended for sar1, > leading to probe failures for sar1 that are quite confusing. > > Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1") > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Matthias Kaehlcke <mka@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > [...] Here is the summary with links: - arm64: dts: qcom: sc7280: Fix sar1_irq_odl node name https://git.kernel.org/qcom/c/f31c834d3976 You are awesome, thank you!
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi index 7c22f0b062be..4d91909af325 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -741,7 +741,7 @@ sar0_irq_odl: sar0-irq-odl { bias-pull-up; }; - sar1_irq_odl: sar0-irq-odl { + sar1_irq_odl: sar1-irq-odl { pins = "gpio140"; function = "gpio"; bias-pull-up;
This node should be named sar1-irq-odl, not sar0-irq-odl. Otherwise we'll overwrite the settings for sar0 with what is intended for sar1, leading to probe failures for sar1 that are quite confusing. Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1") Cc: Douglas Anderson <dianders@chromium.org> Cc: Matthias Kaehlcke <mka@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 116f7cc43d28ccd621ff1fecc9526c65dde28dcd