diff mbox series

[v2,4/4] drm/msm/dp: make dp_connector_mode_valid() more precise

Message ID 20220330223008.649274-5-dmitry.baryshkov@linaro.org (mailing list archive)
State Not Applicable
Headers show
Series drm/msm/dp: simplify dp_connector_get_modes() | expand

Commit Message

Dmitry Baryshkov March 30, 2022, 10:30 p.m. UTC
Make dp_connector_mode_valid() return precise MODE_CLOCK_HIGH rather
than generic MODE_BAD in case the mode clock is higher than
DP_MAX_PIXEL_CLK_KHZ (675 MHz).

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/gpu/drm/msm/dp/dp_drm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kuogee Hsieh April 4, 2022, 5:01 p.m. UTC | #1
On 3/30/2022 3:30 PM, Dmitry Baryshkov wrote:
> Make dp_connector_mode_valid() return precise MODE_CLOCK_HIGH rather
> than generic MODE_BAD in case the mode clock is higher than
> DP_MAX_PIXEL_CLK_KHZ (675 MHz).
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---

Reviewed-by: Kuogee Hsieh<quic_khsieh@quicinc.com>

>   drivers/gpu/drm/msm/dp/dp_drm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c
> index a94c9b34f397..3225435fa81b 100644
> --- a/drivers/gpu/drm/msm/dp/dp_drm.c
> +++ b/drivers/gpu/drm/msm/dp/dp_drm.c
> @@ -89,7 +89,7 @@ static enum drm_mode_status dp_connector_mode_valid(
>   	dp_disp = to_dp_connector(connector)->dp_display;
>   
>   	if (mode->clock > DP_MAX_PIXEL_CLK_KHZ)
> -		return MODE_BAD;
> +		return MODE_CLOCK_HIGH;
>   
>   	return dp_display_validate_mode(dp_disp, mode->clock);
>   }
Stephen Boyd April 6, 2022, 1:58 a.m. UTC | #2
Quoting Dmitry Baryshkov (2022-03-30 15:30:08)
> Make dp_connector_mode_valid() return precise MODE_CLOCK_HIGH rather
> than generic MODE_BAD in case the mode clock is higher than
> DP_MAX_PIXEL_CLK_KHZ (675 MHz).
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---

Suggested-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c
index a94c9b34f397..3225435fa81b 100644
--- a/drivers/gpu/drm/msm/dp/dp_drm.c
+++ b/drivers/gpu/drm/msm/dp/dp_drm.c
@@ -89,7 +89,7 @@  static enum drm_mode_status dp_connector_mode_valid(
 	dp_disp = to_dp_connector(connector)->dp_display;
 
 	if (mode->clock > DP_MAX_PIXEL_CLK_KHZ)
-		return MODE_BAD;
+		return MODE_CLOCK_HIGH;
 
 	return dp_display_validate_mode(dp_disp, mode->clock);
 }