| Message ID | 20220419010903.3109514-2-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add MSM8939 SoC support with two devices | expand |
On 19/04/2022 03:09, Bryan O'Donoghue wrote: > Document the MSM8939 and supported boards in upstream Sony "Tulip" M4 Aqua > and Square APQ8039 T2. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 129cdd246223..0e4f3a4d1a58 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -34,6 +34,7 @@ description: | > mdm9615 > msm8226 > msm8916 > + msm8939 Some indentation mixup. > msm8974 > msm8992 > msm8994 > @@ -133,6 +134,12 @@ properties: > - samsung,s3ve3g > - const: qcom,msm8226 > > + - items: The same > + - enum: > + - square,apq8039-t2 > + - sony,kanuti-tulip Please put them in alphabetical order (so sony, square). > + - const: qcom,msm8939 > + > - items: > - enum: > - qcom,msm8960-cdp Best regards, Krzysztof
On Tue, 19 Apr 2022 02:09:00 +0100, Bryan O'Donoghue wrote: > Document the MSM8939 and supported boards in upstream Sony "Tulip" M4 Aqua > and Square APQ8039 T2. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/arm/qcom.yaml:37:1: [error] syntax error: found character '\t' that cannot start any token (syntax) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/arm/qcom.example.dts' Traceback (most recent call last): File "/usr/local/bin/dt-extract-example", line 52, in <module> binding = yaml.load(open(args.yamlfile, encoding='utf-8').read()) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load return constructor.get_single_data() File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 119, in get_single_data node = self.composer.get_single_node() File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node File "_ruamel_yaml.pyx", line 731, in _ruamel_yaml.CParser._compose_node File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event ruamel.yaml.scanner.ScannerError: while scanning a block scalar in "<unicode string>", line 12, column 14 found a tab character where an indentation space is expected in "<unicode string>", line 37, column 1 make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/arm/qcom.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/arm/qcom.yaml: while scanning a block scalar in "<unicode string>", line 12, column 14 found a tab character where an indentation space is expected in "<unicode string>", line 37, column 1 /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/qcom.yaml: ignoring, error parsing file make: *** [Makefile:1401: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 129cdd246223..0e4f3a4d1a58 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -34,6 +34,7 @@ description: | mdm9615 msm8226 msm8916 + msm8939 msm8974 msm8992 msm8994 @@ -133,6 +134,12 @@ properties: - samsung,s3ve3g - const: qcom,msm8226 + - items: + - enum: + - square,apq8039-t2 + - sony,kanuti-tulip + - const: qcom,msm8939 + - items: - enum: - qcom,msm8960-cdp
Document the MSM8939 and supported boards in upstream Sony "Tulip" M4 Aqua and Square APQ8039 T2. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++ 1 file changed, 7 insertions(+)