| Message ID | 20220421073502.1824089-1-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name | expand |
On 21/04/2022 09:35, Vinod Koul wrote: > Per DT spec node names should not have underscores (_) in them, so > change can_clock to can-clock. > > Fixes: 5c44c564e449 ("arm64: dts: qcom: qrb5165-rb5: Add support for MCP2518FD") > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Apr 21, 2022 at 01:05:02PM +0530, Vinod Koul wrote: > Per DT spec node names should not have underscores (_) in them, so > change can_clock to can-clock. > > Fixes: 5c44c564e449 ("arm64: dts: qcom: qrb5165-rb5: Add support for MCP2518FD") > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > index 845eb7a6bf92..0e63f707b911 100644 > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > @@ -29,7 +29,7 @@ chosen { > }; > > /* Fixed crystal oscillator dedicated to MCP2518FD */ > - clk40M: can_clock { > + clk40M: can-clock { Should the node name be just "clock"? Thanks, Mani > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <40000000>; > -- > 2.34.1 >
On Thu, 21 Apr 2022 13:05:02 +0530, Vinod Koul wrote: > Per DT spec node names should not have underscores (_) in them, so > change can_clock to can-clock. > > Applied, thanks! [1/1] arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name commit: 1eae95fb1d696968ca72be3ac8e0d62bb4d8da42 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts index 845eb7a6bf92..0e63f707b911 100644 --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts @@ -29,7 +29,7 @@ chosen { }; /* Fixed crystal oscillator dedicated to MCP2518FD */ - clk40M: can_clock { + clk40M: can-clock { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <40000000>;
Per DT spec node names should not have underscores (_) in them, so change can_clock to can-clock. Fixes: 5c44c564e449 ("arm64: dts: qcom: qrb5165-rb5: Add support for MCP2518FD") Signed-off-by: Vinod Koul <vkoul@kernel.org> --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)