diff mbox series

[v4,1/4] ARM: dts: qcom: apq8064: Use generic node name for DMA

Message ID 20220421171809.32722-2-singh.kuldeep87k@gmail.com (mailing list archive)
State Superseded
Headers show
Series [v4,1/4] ARM: dts: qcom: apq8064: Use generic node name for DMA | expand

Commit Message

Kuldeep Singh April 21, 2022, 5:18 p.m. UTC 
Qcom BAM DT spec expects generic DMA controller node name as
"dma-controller" to enable validations.

Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-apq8064.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Bjorn Andersson April 23, 2022, 4:03 p.m. UTC | #1 
On Thu 21 Apr 10:18 PDT 2022, Kuldeep Singh wrote:

> Qcom BAM DT spec expects generic DMA controller node name as
> "dma-controller" to enable validations.
> 
> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

It seems that I picked up v3, but patchwork-bot didn't send out any
notifications.

Please double check linux-next to confirm that we got them all sorted
out.

Thanks,
Bjorn

> ---
>  arch/arm/boot/dts/qcom-apq8064.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index a1c8ae516d21..b2975be3ae04 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -1040,7 +1040,7 @@ sata0: sata@29000000 {
>  		};
>  
>  		/* Temporary fixed regulator */
> -		sdcc1bam:dma@12402000{
> +		sdcc1bam: dma-controller@12402000{
>  			compatible = "qcom,bam-v1.3.0";
>  			reg = <0x12402000 0x8000>;
>  			interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1050,7 +1050,7 @@ sdcc1bam:dma@12402000{
>  			qcom,ee = <0>;
>  		};
>  
> -		sdcc3bam:dma@12182000{
> +		sdcc3bam: dma-controller@12182000{
>  			compatible = "qcom,bam-v1.3.0";
>  			reg = <0x12182000 0x8000>;
>  			interrupts = <0 96 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1060,7 +1060,7 @@ sdcc3bam:dma@12182000{
>  			qcom,ee = <0>;
>  		};
>  
> -		sdcc4bam:dma@121c2000{
> +		sdcc4bam: dma-controller@121c2000{
>  			compatible = "qcom,bam-v1.3.0";
>  			reg = <0x121c2000 0x8000>;
>  			interrupts = <0 95 IRQ_TYPE_LEVEL_HIGH>;
> -- 
> 2.25.1
>
Kuldeep Singh April 23, 2022, 6:09 p.m. UTC | #2 
On Sat, Apr 23, 2022 at 09:03:39AM -0700, Bjorn Andersson wrote:
> On Thu 21 Apr 10:18 PDT 2022, Kuldeep Singh wrote:
> 
> > Qcom BAM DT spec expects generic DMA controller node name as
> > "dma-controller" to enable validations.
> > 
> > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> It seems that I picked up v3, but patchwork-bot didn't send out any
> notifications.

Yes, somehow there was no notification for this series as well as geni
uart/i2c patches also.

>
> Please double check linux-next to confirm that we got them all sorted
> out.

I checked dma dts patches[1] and they are in next/linux-next.
I hope I checked the right tree, please correct me if it's wrong.

Please note, there was one small typo fix from v3->v4 in commit
header(s/User/Use). Not sure if it's worth updating as it's already in
next tree, upto you. Thanks!

-Kuldeep
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fb1bdb7e787a6037f501869b5aaf9e5cabe7a7bc
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fbf64afd16b9581ae5a89c6924b50f83041463e0
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=095a7137ba3630bcca11e6017bfd4ab48b7fc12e
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a86efc02b34104b93a0f9707d1e61577671fc4ad
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=7224013d4b5a64c43be23204bcfb4070dbd7fd76
Bjorn Andersson April 26, 2022, 8:49 p.m. UTC | #3 
On Sat 23 Apr 11:09 PDT 2022, Kuldeep Singh wrote:

> On Sat, Apr 23, 2022 at 09:03:39AM -0700, Bjorn Andersson wrote:
> > On Thu 21 Apr 10:18 PDT 2022, Kuldeep Singh wrote:
> > 
> > > Qcom BAM DT spec expects generic DMA controller node name as
> > > "dma-controller" to enable validations.
> > > 
> > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > 
> > It seems that I picked up v3, but patchwork-bot didn't send out any
> > notifications.
> 
> Yes, somehow there was no notification for this series as well as geni
> uart/i2c patches also.
> 
> >
> > Please double check linux-next to confirm that we got them all sorted
> > out.
> 
> I checked dma dts patches[1] and they are in next/linux-next.
> I hope I checked the right tree, please correct me if it's wrong.
> 
> Please note, there was one small typo fix from v3->v4 in commit
> header(s/User/Use). Not sure if it's worth updating as it's already in
> next tree, upto you. Thanks!
> 

I generally never rebase my trees, as that's causing issues for anyone
references commits in my tree. So we'll have to live with this typo.

Thanks,
Bjorn
Kuldeep Singh April 28, 2022, 1:39 a.m. UTC | #4 
> I generally never rebase my trees, as that's causing issues for anyone
> references commits in my tree. So we'll have to live with this typo.

Sure Bjorn, this was completely unintentional and next time, will try to
fix it before it's accepted. Thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
index a1c8ae516d21..b2975be3ae04 100644
--- a/arch/arm/boot/dts/qcom-apq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
@@ -1040,7 +1040,7 @@  sata0: sata@29000000 {
 		};
 
 		/* Temporary fixed regulator */
-		sdcc1bam:dma@12402000{
+		sdcc1bam: dma-controller@12402000{
 			compatible = "qcom,bam-v1.3.0";
 			reg = <0x12402000 0x8000>;
 			interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
@@ -1050,7 +1050,7 @@  sdcc1bam:dma@12402000{
 			qcom,ee = <0>;
 		};
 
-		sdcc3bam:dma@12182000{
+		sdcc3bam: dma-controller@12182000{
 			compatible = "qcom,bam-v1.3.0";
 			reg = <0x12182000 0x8000>;
 			interrupts = <0 96 IRQ_TYPE_LEVEL_HIGH>;
@@ -1060,7 +1060,7 @@  sdcc3bam:dma@12182000{
 			qcom,ee = <0>;
 		};
 
-		sdcc4bam:dma@121c2000{
+		sdcc4bam: dma-controller@121c2000{
 			compatible = "qcom,bam-v1.3.0";
 			reg = <0x121c2000 0x8000>;
 			interrupts = <0 95 IRQ_TYPE_LEVEL_HIGH>;