| Message ID | 20220424032418.3173632-1-lv.ruyi@zte.com.cn (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2] drm/msm/dp: fix error check return value of irq_of_parse_and_map() | expand |
On 24/04/2022 06:24, cgel.zte@gmail.com wrote: > From: Lv Ruyi <lv.ruyi@zte.com.cn> > > The irq_of_parse_and_map() function returns 0 on failure, and does not > return an negative value. > > Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > v2: don't print rc, and return -EINVAL rather than 0 > --- > drivers/gpu/drm/msm/dp/dp_display.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index a42732b67349..c3566e6564b1 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1239,10 +1239,9 @@ int dp_display_request_irq(struct msm_dp *dp_display) > dp = container_of(dp_display, struct dp_display_private, dp_display); > > dp->irq = irq_of_parse_and_map(dp->pdev->dev.of_node, 0); > - if (dp->irq < 0) { > - rc = dp->irq; > - DRM_ERROR("failed to get irq: %d\n", rc); > - return rc; > + if (!dp->irq) { > + DRM_ERROR("failed to get irq\n"); > + return -EINVAL; > } > > rc = devm_request_irq(&dp->pdev->dev, dp->irq,
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index a42732b67349..c3566e6564b1 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -1239,10 +1239,9 @@ int dp_display_request_irq(struct msm_dp *dp_display) dp = container_of(dp_display, struct dp_display_private, dp_display); dp->irq = irq_of_parse_and_map(dp->pdev->dev.of_node, 0); - if (dp->irq < 0) { - rc = dp->irq; - DRM_ERROR("failed to get irq: %d\n", rc); - return rc; + if (!dp->irq) { + DRM_ERROR("failed to get irq\n"); + return -EINVAL; } rc = devm_request_irq(&dp->pdev->dev, dp->irq,