diff mbox series

[v4,2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

Message ID 20220426101837.16201-2-david@ixit.cz (mailing list archive)
State Not Applicable
Headers show
Series [v4,1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 | expand

Commit Message

David Heidelberg April 26, 2022, 10:18 a.m. UTC
These missing required properties are needed for
smp2p binding reference checks.

Also includes cosmetic change to the example formatting.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
v3:
 - add Krzysztof R-b
---
 .../devicetree/bindings/mailbox/qcom-ipcc.yaml        | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Comments

Krzysztof Kozlowski April 26, 2022, 10:34 a.m. UTC | #1
On 26/04/2022 12:18, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
> 
> Also includes cosmetic change to the example formatting.
> 

Missing reported-by:
Reported-by: Rob Herring <robh@kernel.org>

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> v3:
>  - add Krzysztof R-b

BTW, this patch confuses me a bit... You sent it some time after I sent
a fix:
https://lore.kernel.org/all/20220402155551.16509-1-krzysztof.kozlowski@linaro.org/


Best regards,
Krzysztof
Manivannan Sadhasivam April 27, 2022, 2:28 p.m. UTC | #2
On Tue, Apr 26, 2022 at 12:18:37PM +0200, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
> 
> Also includes cosmetic change to the example formatting.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Thanks,
Mani

> ---
> v3:
>  - add Krzysztof R-b
> ---
>  .../devicetree/bindings/mailbox/qcom-ipcc.yaml        | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> index c57dd423e98c..50f9aa72c670 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> @@ -76,9 +76,14 @@ examples:
>  
>          smp2p-modem {
>                  compatible = "qcom,smp2p";
> -                interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
> -                                IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
> -                mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
> +                qcom,smem = <443>, <429>;
> +                interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
> +                                             IPCC_MPROC_SIGNAL_SMP2P
> +                                             IRQ_TYPE_EDGE_RISING>;
> +                mboxes = <&ipcc IPCC_CLIENT_LPASS
> +                                IPCC_MPROC_SIGNAL_SMP2P>;
>  
> +                qcom,local-pid = <0>;
> +                qcom,remote-pid = <2>;
>                  /* Other SMP2P fields */
>          };
> -- 
> 2.35.1
>
Rob Herring (Arm) May 3, 2022, 12:09 a.m. UTC | #3
On Tue, Apr 26, 2022 at 12:18:37PM +0200, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
> 
> Also includes cosmetic change to the example formatting.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> v3:
>  - add Krzysztof R-b
> ---
>  .../devicetree/bindings/mailbox/qcom-ipcc.yaml        | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)

Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
index c57dd423e98c..50f9aa72c670 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
@@ -76,9 +76,14 @@  examples:
 
         smp2p-modem {
                 compatible = "qcom,smp2p";
-                interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
-                                IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
-                mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
+                qcom,smem = <443>, <429>;
+                interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
+                                             IPCC_MPROC_SIGNAL_SMP2P
+                                             IRQ_TYPE_EDGE_RISING>;
+                mboxes = <&ipcc IPCC_CLIENT_LPASS
+                                IPCC_MPROC_SIGNAL_SMP2P>;
 
+                qcom,local-pid = <0>;
+                qcom,remote-pid = <2>;
                 /* Other SMP2P fields */
         };