From patchwork Fri Apr 29 23:43:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 12832996 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69CB5C433EF for ; Fri, 29 Apr 2022 23:43:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239920AbiD2XrQ (ORCPT ); Fri, 29 Apr 2022 19:47:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239911AbiD2XrP (ORCPT ); Fri, 29 Apr 2022 19:47:15 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB8FEDB0EC for ; Fri, 29 Apr 2022 16:43:55 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id 7so3711915pga.12 for ; Fri, 29 Apr 2022 16:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wiS8qEoWRaz1WJHgDpdYQzj9UXTuORSLeUZZBuLbpAQ=; b=QfV9qZQSy7zKpLgp3XKRuVVGQgXKgCEdZT8M6YLWLWuzskyledgrDoNbnEeL6+vdAy J1x4CD4N/XKato7QqwqelKbTKiWvYbwUH3sZuY4jCfH6bKi9uUj8MsW6jOFLQXVjURAX OatmJuCqt75DW8gtrxh6zZLgi05jRW6xz/fmM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wiS8qEoWRaz1WJHgDpdYQzj9UXTuORSLeUZZBuLbpAQ=; b=47FfQy0U/sjVwsHQC1wwnLjRHnCFciO+IJRw2D1MOrgigGTI3SFHtJSExK6ubRh24c scsL6R8dCtctQiOanZmm9cAxMWMXKsoVw4psRXV3XUmFDxbOBWYN2A2Sd13+mT/wk4/+ zSxRRqnPV4KeTCl0/kZnJdoHAgX5Nl+LZ3k7kqZkl5H2biP9LFvslLUNzL32F0nocq0/ eFemO2s/QpOZ24vGVm6dr1GxZCo3BeunV7WUMrXBO2Eq7cPP1zhE538TYsrTAnhEUOTE izNfoEWDUwlNwt2g9DKSOwQy1rSrFOubJdiuyMVseG3qXYI4+n5xAndlrLgesdWZMAk5 2J6Q== X-Gm-Message-State: AOAM533XIX7EHY83vQoZhtALg/q0ae1wguw1gGCPX9oT0LiPbheTE/9q W2pfMi1q7mA1BQ0rVvNvn8vUyg== X-Google-Smtp-Source: ABdhPJyGwn4LqJY11HpxsF3RCIIDl8jF0wjSNEEMrwJ5U7v246J/p3J5Kt/Ft8+Hq1Ze7VFy0q1q0g== X-Received: by 2002:a05:6a00:190f:b0:50d:8b82:cb90 with SMTP id y15-20020a056a00190f00b0050d8b82cb90mr1532752pfi.65.1651275835135; Fri, 29 Apr 2022 16:43:55 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:408:3697:902b:59f1]) by smtp.gmail.com with ESMTPSA id r1-20020a1709028bc100b0015e8d4eb26dsm152563plo.183.2022.04.29.16.43.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 16:43:54 -0700 (PDT) From: Douglas Anderson To: "Rafael J . Wysocki" Cc: swboyd@chromium.org, Andy Shevchenko , freedreno@lists.freedesktop.org, Saravana Kannan , Bjorn Andersson , Sakari Ailus , linux-arm-msm@vger.kernel.org, Douglas Anderson , Daniel Scally , Greg Kroah-Hartman , Heikki Krogerus , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] device property: Fix recent breakage of fwnode_get_next_parent_dev() Date: Fri, 29 Apr 2022 16:43:47 -0700 Message-Id: <20220429164325.1.I2a3b980ea051e59140227999f0f0ca16f1125768@changeid> X-Mailer: git-send-email 2.36.0.464.gb9c8b46e94-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Due to a subtle typo, instead of commit 87ffea09470d ("device property: Introduce fwnode_for_each_parent_node()") being a no-op change, it ended up causing the display on my sc7180-trogdor-lazor device from coming up unless I added "fw_devlink=off" to my kernel command line. Fix the typo. Fixes: 87ffea09470d ("device property: Introduce fwnode_for_each_parent_node()") Signed-off-by: Douglas Anderson Reviewed-by: Saravana Kannan Reviewed-by: Sakari Ailus Reviewed-by: Andy Shevchenko --- drivers/base/property.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/property.c b/drivers/base/property.c index 36401cfe432c..52e85dcb20b5 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -600,7 +600,7 @@ struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode) struct device *dev; fwnode_for_each_parent_node(fwnode, parent) { - dev = get_dev_from_fwnode(fwnode); + dev = get_dev_from_fwnode(parent); if (dev) { fwnode_handle_put(parent); return dev;