| Message ID | 20220501103428.111286-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/2] mailbox: correct kerneldoc | expand |
> Subject: [PATCH 2/2] mailbox: imx: fix duplicated initializer > > rxdb field is being initialized twice: > > drivers/mailbox/imx-mailbox.c:889:19: error: initialized field overwritten [- > Werror=override-init] > 889 | .rxdb = imx_mu_generic_rxdb, > > Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/mailbox/imx-mailbox.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c > index e88f544a1548..df8a785be324 100644 > --- a/drivers/mailbox/imx-mailbox.c > +++ b/drivers/mailbox/imx-mailbox.c > @@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = > { > .rx = imx_mu_generic_rx, > .rxdb = imx_mu_generic_rxdb, > .init = imx_mu_init_generic, > - .rxdb = imx_mu_generic_rxdb, > .type = IMX_MU_V2, > .xTR = 0x200, > .xRR = 0x280, > -- > 2.32.0
On 07/05/2022 08:52, Peng Fan wrote: >> Subject: [PATCH 2/2] mailbox: imx: fix duplicated initializer >> >> rxdb field is being initialized twice: >> >> drivers/mailbox/imx-mailbox.c:889:19: error: initialized field overwritten [- >> Werror=override-init] >> 889 | .rxdb = imx_mu_generic_rxdb, >> >> Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback") >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Peng Fan <peng.fan@nxp.com> Thanks for the review. This was a month ago... Anyone willing to pick it up? Best regards, Krzysztof
On Mon, Jun 20, 2022 at 1:39 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 07/05/2022 08:52, Peng Fan wrote: > >> Subject: [PATCH 2/2] mailbox: imx: fix duplicated initializer > >> > >> rxdb field is being initialized twice: > >> > >> drivers/mailbox/imx-mailbox.c:889:19: error: initialized field overwritten [- > >> Werror=override-init] > >> 889 | .rxdb = imx_mu_generic_rxdb, > >> > >> Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback") > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Reviewed-by: Peng Fan <peng.fan@nxp.com> > > Thanks for the review. This was a month ago... Anyone willing to pick it up? > There was a predated fix, which was picked. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/mailbox?id=262190a8ca2b1e1ec75b8a4f1c7f07e585facd6f Thanks.
diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c index e88f544a1548..df8a785be324 100644 --- a/drivers/mailbox/imx-mailbox.c +++ b/drivers/mailbox/imx-mailbox.c @@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = { .rx = imx_mu_generic_rx, .rxdb = imx_mu_generic_rxdb, .init = imx_mu_init_generic, - .rxdb = imx_mu_generic_rxdb, .type = IMX_MU_V2, .xTR = 0x200, .xRR = 0x280,
rxdb field is being initialized twice: drivers/mailbox/imx-mailbox.c:889:19: error: initialized field overwritten [-Werror=override-init] 889 | .rxdb = imx_mu_generic_rxdb, Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/mailbox/imx-mailbox.c | 1 - 1 file changed, 1 deletion(-)